Skip to content

Commit 2b3fe84

Browse files
authored
Bazel build for Zipkin (#916)
1 parent 2037fa7 commit 2b3fe84

File tree

3 files changed

+46
-3
lines changed

3 files changed

+46
-3
lines changed

exporters/zipkin/BUILD

+44
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
package(default_visibility = ["//visibility:public"])
2+
3+
cc_library(
4+
name = "zipkin_recordable",
5+
srcs = [
6+
"src/recordable.cc",
7+
],
8+
hdrs = [
9+
"include/opentelemetry/exporters/zipkin/recordable.h",
10+
],
11+
strip_include_prefix = "include",
12+
deps = [
13+
"//sdk/src/resource",
14+
"//sdk/src/trace",
15+
"@github_nlohmann_json//:json",
16+
],
17+
)
18+
19+
cc_library(
20+
name = "zipkin_exporter",
21+
srcs = [
22+
"src/zipkin_exporter.cc",
23+
],
24+
hdrs = [
25+
"include/opentelemetry/exporters/zipkin/zipkin_exporter.h",
26+
],
27+
copts = [
28+
"-DCURL_STATICLIB",
29+
],
30+
strip_include_prefix = "include",
31+
deps = [
32+
":zipkin_recordable",
33+
"//ext/src/http/client/curl:http_client_curl",
34+
],
35+
)
36+
37+
cc_test(
38+
name = "zipkin_recordable_test",
39+
srcs = ["test/zipkin_recordable_test.cc"],
40+
deps = [
41+
":zipkin_recordable",
42+
"@com_google_googletest//:gtest_main",
43+
],
44+
)

exporters/zipkin/src/zipkin_exporter.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ sdk::common::ExportResult ZipkinExporter::Export(
6262
auto body_s = json_spans.dump();
6363
http_client::Body body_v(body_s.begin(), body_s.end());
6464
auto result = http_client_->Post(url_parser_.url_, body_v);
65-
if (result && result.GetResponse().GetStatusCode() == 200 ||
66-
result.GetResponse().GetStatusCode() == 202)
65+
if (result &&
66+
(result.GetResponse().GetStatusCode() == 200 || result.GetResponse().GetStatusCode() == 202))
6767
{
6868
return sdk::common::ExportResult::kSuccess;
6969
}

exporters/zipkin/test/zipkin_recordable_test.cc

-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,6 @@ TEST(ZipkinSpanRecordable, AddEventDefault)
144144
TEST(ZipkinSpanRecordable, AddEventWithAttributes)
145145
{
146146
opentelemetry::exporter::zipkin::Recordable rec;
147-
nostd::string_view name = "Test Event";
148147

149148
std::chrono::system_clock::time_point event_time = std::chrono::system_clock::now();
150149
opentelemetry::common::SystemTimestamp event_timestamp(event_time);

0 commit comments

Comments
 (0)