Fix clang tidy warning

chusitoo · chusitoo · commit 905e7aeda9b6 · 2025-01-17T08:25:17.000-05:00
diff --git a/ext/src/http/client/curl/http_client_curl.cc b/ext/src/http/client/curl/http_client_curl.cc
@@ -830,9 +830,9 @@ bool HttpClient::doRemoveSessions()
   return has_data;
 }
 
+#ifdef ENABLE_OTLP_RETRY_PREVIEW
 bool HttpClient::doRetrySessions(bool report_all)
 {
-#ifdef ENABLE_OTLP_RETRY_PREVIEW
   const auto now = std::chrono::system_clock::now();
   auto has_data  = false;
 
@@ -866,10 +866,13 @@ bool HttpClient::doRetrySessions(bool report_all)
 
   report_all = report_all && !pending_to_retry_sessions_.empty();
   return has_data || report_all;
+}
 #else
+bool HttpClient::doRetrySessions(bool /* report_all */)
+{
   return false;
-#endif  // ENABLE_OTLP_RETRY_PREVIEW
 }
+#endif  // ENABLE_OTLP_RETRY_PREVIEW
 
 void HttpClient::resetMultiHandle()
 {

Original file line number	Diff line number	Diff line change
`@@ -830,9 +830,9 @@ bool HttpClient::doRemoveSessions()`
`830`	`830`	`return has_data;`
`831`	`831`	`}`
`832`	`832`
	`833`	`+#ifdef ENABLE_OTLP_RETRY_PREVIEW`
`833`	`834`	`bool HttpClient::doRetrySessions(bool report_all)`
`834`	`835`	`{`
`835`		`-#ifdef ENABLE_OTLP_RETRY_PREVIEW`
`836`	`836`	`const auto now = std::chrono::system_clock::now();`
`837`	`837`	`auto has_data = false;`
`838`	`838`
`@@ -866,10 +866,13 @@ bool HttpClient::doRetrySessions(bool report_all)`
`866`	`866`
`867`	`867`	`report_all = report_all && !pending_to_retry_sessions_.empty();`
`868`	`868`	`return has_data \|\| report_all;`
	`869`	`+}`
`869`	`870`	`#else`
	`871`	`+bool HttpClient::doRetrySessions(bool /* report_all */)`
	`872`	`+{`
`870`	`873`	`return false;`
`871`		`-#endif // ENABLE_OTLP_RETRY_PREVIEW`
`872`	`874`	`}`
	`875`	`+#endif // ENABLE_OTLP_RETRY_PREVIEW`
`873`	`876`
`874`	`877`	`void HttpClient::resetMultiHandle()`
`875`	`878`	`{`