Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics SDK] Make cardinality limit configurable #3292

Open
lalitb opened this issue Mar 6, 2025 · 2 comments · May be fixed by #3299
Open

[Metrics SDK] Make cardinality limit configurable #3292

lalitb opened this issue Mar 6, 2025 · 2 comments · May be fixed by #3299
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@lalitb
Copy link
Member

lalitb commented Mar 6, 2025

As per the specs, there are 3 ways to configure cardinality limit:

The cardinality limit for an aggregation is defined in one of three ways:

  • A view with criteria matching the instrument an aggregation is created for has an aggregation_cardinality_limit value defined for the stream, that value SHOULD be used.
  • If there is no matching view, but the MetricReader defines a default cardinality limit value based on the instrument an aggregation is created for, that value SHOULD be used.
  • If none of the previous values are defined, the default value of 2000 SHOULD be used.

The implementation currently imposes the limit to be 2000. And the measurement beyond this would be aggregated as part of overflow attribute.
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 6, 2025
@lalitb lalitb mentioned this issue Mar 6, 2025
Open
4 tasks
@marcalff marcalff added help wanted Good for taking. Extra help will be provided by maintainers triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

This issue is available for anyone to work on. Make sure to reference this issue in your pull request.
✨ Thank you for your contribution! ✨

@marcalff marcalff added the good first issue Good for newcomers label Mar 7, 2025
@akshatakulkarni25
Copy link

Hi, i would like to contribute to this issue. What would be a good starting point?

@lalitb lalitb linked a pull request Mar 12, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
3 participants
@lalitb @marcalff @akshatakulkarni25