Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "semver" prefixes in documentation and tests #2179

Closed
arminru opened this issue Dec 2, 2020 · 0 comments · Fixed by #2180
Closed

Remove "semver" prefixes in documentation and tests #2179

arminru opened this issue Dec 2, 2020 · 0 comments · Fixed by #2180

Comments

@arminru
Copy link
Member

arminru commented Dec 2, 2020

The semver prefix for versions was removed from the spec a while ago (open-telemetry/opentelemetry-specification#802, open-telemetry/opentelemetry-specification#873) but some Java tests and documentation including the quickstart guide are still using this notation:

Tracer tracer =
OpenTelemetry.getGlobalTracer("instrumentation-library-name","semver:1.0.0");

Meter meter = OpenTelemetry.getGlobalMeter("instrumentation-library-name","semver:1.0.0");

* @param instrumentationVersion The version of the instrumentation library (e.g.,
* "semver:1.0.0").

* @param instrumentationVersion The version of the instrumentation library (e.g.,
* "semver:1.0.0").

() -> InstrumentationLibraryInfo.create(null, "semver:1.0.0"),

private static final String INSTRUMENTATION_LIBRARY_VERSION = "semver:0.2.0";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants