Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Extract documentation, and possible fix implementations #2913

Closed
bogdandrutu opened this issue Feb 23, 2021 · 1 comment
Closed

Fix Extract documentation, and possible fix implementations #2913

bogdandrutu opened this issue Feb 23, 2021 · 1 comment
Labels
Bug Something isn't working documentation
Milestone

Comments

@bogdandrutu
Copy link
Member

Describe the bug
The specs says:
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/context/api-propagators.md#extract

Our documentation says:
https://github.com/open-telemetry/opentelemetry-java/blob/main/api/context/src/main/java/io/opentelemetry/context/propagation/TextMapPropagator.java#L113

Steps to reproduce
If possible, provide a recipe for reproducing the error.

What did you expect to see?
A contract compatible with the specification.

What did you see instead?
A contract incompatible with the specification.

@bogdandrutu
Copy link
Member Author

Documentation was updated, the verification/implementation is tracked in #2933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working documentation
Projects
None yet
Development

No branches or pull requests

1 participant