Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate environment variables which do not interoperate with file config when ready for stabilization #3967

Open
jack-berg opened this issue Mar 28, 2024 · 2 comments
Assignees
Labels
area:configuration Related to configuring the SDK triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor

Comments

@jack-berg
Copy link
Member

As discussed here, we do not want to recommend multiple competing configuration stores. When file configuration is ready for stabilization, we should deprecate any environment variables which do not interoperate.

@jack-berg jack-berg added the area:configuration Related to configuring the SDK label Mar 28, 2024
@dyladan dyladan assigned jack-berg and unassigned yurishkuro Mar 29, 2024
@dyladan dyladan added the triage:accepted:ready-with-sponsor Ready to be implemented and has a specification sponsor assigned label Mar 29, 2024
@austinlparker austinlparker moved this to Spec - Accepted in Specification + OTEPs Jul 16, 2024
@austinlparker austinlparker moved this from Spec - Accepted to Spec - In Progress in Specification + OTEPs Jul 16, 2024
@austinlparker austinlparker added triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor and removed triage:accepted:ready-with-sponsor Ready to be implemented and has a specification sponsor assigned labels Jul 30, 2024
@VidhiPhatnani
Copy link

Issue: When attempting to use both the otel-profiling JAR (for trace-to-profiling linking) and the opentelemetry-samplers JAR (specified via OTEL_JAVAAGENT_EXTENSIONS env variable), the Opentelemetry Java Agent does not handle them together.

  • If only otel-profiling jar is set as an environment variable, profiling and linking work correctly.
  • If both the otel-profiling jar as env variable as well as opentelemetry-samplers jar as jvm arg ( -Dotel.javaagent.extensions ) are set then the trace-to-profiling linking stops working, but the SDK configuration is correctly applied.

Additionally, the sdk-config.yaml does not seem to support any other jar when provided as an environment variable.

I would really appreciate any guidance on resolving this issue. Thank you for the insights.

@jack-berg
Copy link
Member Author

I'm not familiar with the otel-profiling jar - can you link to the source code for that?

Additionally, the sdk-config.yaml does not seem to support any other jar when provided as an environment variable.

Can you elaborate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:configuration Related to configuring the SDK triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor
Projects
Status: Spec - In Progress
Development

No branches or pull requests

5 participants