Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Pausing state, update docs #3343

Closed
kolyshkin opened this issue Jan 20, 2022 · 4 comments
Closed

remove Pausing state, update docs #3343

kolyshkin opened this issue Jan 20, 2022 · 4 comments

Comments

@kolyshkin
Copy link
Contributor

kolyshkin commented Jan 20, 2022

This needs to be done after merging #3316.

The "Pausing" state of container is not used, and the Pause() docs incorrectly says that it works asynchronously.

Need to

  • remove Pausing state entirely;
  • update the docs (make them conform to golang style)

Ref: #3316 (comment)

@kolyshkin kolyshkin mentioned this issue Jan 20, 2022
7 tasks
@danishprakash
Copy link
Contributor

Hey @kolyshkin, is this something a new contributor to the project can pick up? Please correct me If I'm understanding it incorrectly, but is it as trivial as getting rid of the Pausing state(and all it's references) from within libcontainer and subsequently even runc?

// Pausing is the status that denotes the container exists, it is in the process of being paused.
Pausing

@kolyshkin
Copy link
Contributor Author

@danishprakash yes, you can try removing Pausing state from this code entirely, feel free to open a PR.

In general, you can also contribute by reviewing existing PRs, suggesting improvements and asking questions in there.

@danishprakash
Copy link
Contributor

Hey @kolyshkin I just noticed this is still open since we have one pending item on this issue. Just checking before I make changes, do we simply mean to update the docs to now reflect the removal of Pausing state? Also, when you say conforming to Golang style, do you mean docs in general or something else? Thanks

@kolyshkin
Copy link
Contributor Author

This is now fully fixed, no pending tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants