-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Pausing state, update docs #3343
Comments
Hey @kolyshkin, is this something a new contributor to the project can pick up? Please correct me If I'm understanding it incorrectly, but is it as trivial as getting rid of the Pausing state(and all it's references) from within libcontainer and subsequently even runc? runc/libcontainer/container.go Lines 23 to 24 in 5547b57
|
@danishprakash yes, you can try removing In general, you can also contribute by reviewing existing PRs, suggesting improvements and asking questions in there. |
Hey @kolyshkin I just noticed this is still open since we have one pending item on this issue. Just checking before I make changes, do we simply mean to update the docs to now reflect the removal of |
This is now fully fixed, no pending tasks. |
This needs to be done after merging #3316.
The "Pausing" state of container is not used, and the Pause() docs incorrectly says that it works asynchronously.
Need to
Ref: #3316 (comment)
The text was updated successfully, but these errors were encountered: