Skip to content

Commit 1f0e947

Browse files
committed
Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests
The latest version of chromedriver is 112.0.1 which does not support node 14. This PR hardcodes chromedriver to 112.0.0 temporarily. Pls revert it once we bump to node 18. Issue Resolved #3975 Signed-off-by: ananzh <ananzh@amazon.com>
1 parent ca0bb8f commit 1f0e947

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
210210
- Prevent primitive linting limitations from being applied to unit tests found under `src/setup_node_env` ([#3403](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3403))
211211
- [Tests] Fix unit tests for `get_keystore` ([#3854](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3854))
212212
- [Tests] Use `scripts/use_node` instead of `node` in functional test plugins ([#3783](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3783))
213+
- Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests ([#3976](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3976))
213214

214215
## [2.x]
215216

scripts/upgrade_chromedriver.js

+6-5
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,9 @@ if (majorVersion) {
7474
if (process.argv.includes('--install')) {
7575
console.log(`Installing chromedriver@^${majorVersion}`);
7676

77-
spawnSync(`yarn add --dev chromedriver@^${majorVersion}`, {
77+
// TODO: Temporary fix to install chromedriver 112.0.0; revert this once Node is bumped to 16+.
78+
// https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3975
79+
spawnSync('yarn add --dev chromedriver@112.0.0', {
7880
stdio: 'inherit',
7981
cwd: process.cwd(),
8082
shell: true,
@@ -90,10 +92,9 @@ if (majorVersion) {
9092
});
9193
rl.on('line', (line) => {
9294
if (line.includes('"chromedriver": "')) {
93-
line = line.replace(
94-
/"chromedriver":\s*"[~^]?\d[\d.]*\d"/,
95-
`"chromedriver": "^${majorVersion}"`
96-
);
95+
// TODO: Temporary fix to install chromedriver 112.0.0; revert this once Node is bumped to 16+.
96+
// https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3975
97+
line = line.replace(/"chromedriver":\s*"[~^]?\d[\d.]*\d"/, `"chromedriver": "112.0.0"`);
9798
upgraded = true;
9899
}
99100
writeStream.write(line + '\n', 'utf8');

0 commit comments

Comments
 (0)