Skip to content

Commit 41b1eda

Browse files
SergeyMyssakandreymyssakjoshuarrrr
authored
[CCI] Add new or remove extra tags and styles in saved_objects_management plugin (#4069)
* Add new or remove extra tags and styles (#3967) Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> * Remove extra Fragment tags (#3967) Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> --------- Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> Co-authored-by: Josh Romero <rmerqg@amazon.com>
1 parent 72e7068 commit 41b1eda

File tree

10 files changed

+128
-141
lines changed

10 files changed

+128
-141
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
8888
- [Vis Colors] [Timeline] Replace `vis_type_timeline` colors with `ouiPaletteColorBlind()` ([#4366](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4366))
8989
- [Vis Colors] Update legacy seed colors to use `ouiPaletteColorBlind()` ([#4348](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4348))
9090
- [Vis colors] Update legacy mapped colors in charts plugin to use `ouiPaletteColorBlind()`, Update default color in legacy visualizations to use `ouiPaletteColorBlind()[0]` ([#4398](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4398))
91+
- [Saved Objects Management] Add new or remove extra tags and styles ([#4069](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4069))
9192
- [Console] Migrate `/lib/mappings/` module to TypeScript ([#4008](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4008))
9293

9394
### 🔩 Tests

src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/intro.test.tsx.snap

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap

+15-15
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/plugins/saved_objects_management/public/management_section/object_view/components/intro.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,12 @@ export const Intro = () => {
4444
iconType="alert"
4545
color="warning"
4646
>
47-
<div>
47+
<p>
4848
<FormattedMessage
4949
id="savedObjectsManagement.view.howToModifyObjectDescription"
5050
defaultMessage="Modifying objects is for advanced users only. Object properties are not validated and invalid objects could cause errors, data loss, or worse. Unless someone with intimate knowledge of the code told you to be in here, you probably shouldn&rsquo;t be."
5151
/>
52-
</div>
52+
</p>
5353
</EuiCallOut>
5454
);
5555
};

src/plugins/saved_objects_management/public/management_section/object_view/components/not_found_errors.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,13 @@ export const NotFoundErrors = ({ type }: NotFoundErrors) => {
7676
iconType="alert"
7777
color="danger"
7878
>
79-
<div>{getMessage()}</div>
80-
<div>
79+
<p>{getMessage()}</p>
80+
<p>
8181
<FormattedMessage
8282
id="savedObjectsManagement.view.howToFixErrorDescription"
8383
defaultMessage="If you know what this error means, go ahead and fix it &mdash; otherwise click the delete button above."
8484
/>
85-
</div>
85+
</p>
8686
</EuiCallOut>
8787
);
8888
};

src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/flyout.test.tsx.snap

+94-100
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/relationships.test.tsx.snap

+6-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)