fix: clear discover summary if t2ppl failed (#9552)

* fix: clear discover summary if t2ppl failed

+ removed the placeholder of last ask question

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* Changeset file for PR #9552 created/updated

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

Author: ruanyl

changelogs/fragments/9552.yml

@@ -0,0 +1,3 @@
+fix:
+- Clear discover summary if t2ppl failed ([#9552](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9552))
+- Query-assist removed the placeholder of last ask question ([#9552](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9552))

src/plugins/query_enhancements/public/query_assist/components/query_assist_bar.tsx

@@ -82,6 +82,10 @@ export const QueryAssistBar: React.FC<QueryAssistInputProps> = (props) => {
       } else {
         services.notifications.toasts.addError(error, { title: 'Failed to generate results' });
       }
+      updateQueryState({
+        question: previousQuestionRef.current,
+        generatedQuery: '', // query generate failed, set it to empty
+      });
     } else if (response) {
       services.data.query.queryString.setQuery({
         query: response.query,

src/plugins/query_enhancements/public/query_assist/components/query_assist_input.tsx

@@ -87,16 +87,15 @@ export const QueryAssistInput: React.FC<QueryAssistInputProps> = (props) => {
           onChange={(e) => setValue(e.target.value)}
           onKeyDown={() => setIsSuggestionsVisible(true)}
           placeholder={
-            props.previousQuestion ||
-            (props.selectedIndex
+            props.selectedIndex
               ? i18n.translate('queryEnhancements.queryAssist.input.placeholderWithIndex', {
                   defaultMessage:
                     'Ask a natural language question about {selectedIndex} to generate a query',
                   values: { selectedIndex: props.selectedIndex },
                 })
               : i18n.translate('queryEnhancements.queryAssist.input.placeholderWithoutIndex', {
                   defaultMessage: 'Select an index to ask a question',
-                }))
+                })
           }
           prepend={<EuiIcon type={assistantMark} />}
           append={<WarningBadge error={props.error} />}

src/plugins/query_enhancements/public/query_assist/components/query_assist_summary.tsx

@@ -18,7 +18,7 @@ import React, { useEffect, useState, useCallback, useRef } from 'react';
 import { i18n } from '@osd/i18n';
 import { IDataFrame } from 'src/plugins/data/common';
 import { v4 as uuidv4 } from 'uuid';
-import { isEmpty, isEqual } from 'lodash';
+import { isEmpty } from 'lodash';
 import { filter, distinctUntilChanged } from 'rxjs/operators';
 import { HttpSetup } from 'opensearch-dashboards/public';
 import { QueryAssistState, useQueryAssist } from '../hooks';
@@ -151,7 +151,7 @@ export const QueryAssistSummary: React.FC<QueryAssistSummaryProps> = (props) =>
         filter((value) => !isEmpty(value) && !isEmpty(value?.fields))
       )
       .subscribe((df) => {
-        if (df && currentQueryStateRef.current.question) {
+        if (df) {
           setResults(convertResult(df));
         }
       });
@@ -275,7 +275,7 @@ export const QueryAssistSummary: React.FC<QueryAssistSummaryProps> = (props) =>
       return (
         <EuiText size="s" data-test-subj="queryAssist_summary_can_not_generate">
           {i18n.translate('queryEnhancements.queryAssist.summary.canNotGenerate', {
-            defaultMessage: 'Summary unavailable, please check if there were results.',
+            defaultMessage: 'Summary unavailable, please check if there were results or errors.',
           })}
         </EuiText>
       );