Skip to content

Commit b04e657

Browse files
authored
[Console] [CCI] Remove unused ul element and its custom styling. (#3993)
* remove unused ul element Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> * Update CHANGELOG.md Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
1 parent 2c33d57 commit b04e657

File tree

3 files changed

+1
-13
lines changed

3 files changed

+1
-13
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
199199
- [Console] Replace jQuery.ajax with core.http when calling OSD APIs in console ([#3080](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3080))
200200
- [I18n] Fix Listr type errors and error handlers ([#3629](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3629))
201201
- [Multiple DataSource] Present the authentication type choices in a drop-down ([#3693](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3693))
202+
- [Console] Remove unused ul element and its custom styling ([#3993](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3993))
202203
- Fix EUI/OUI type errors ([#3798](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3798))
203204

204205
### 🔩 Tests

src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ function EditorUI({ initialTextValue, dataSourceId }: EditorProps) {
231231
return (
232232
<div style={abs} className="conApp">
233233
<div className="conApp__editor">
234-
<ul className="conApp__autoComplete" id="autocomplete" />
235234
<EuiFlexGroup
236235
className="conApp__editorActions"
237236
id="ConAppEditorActions"

src/plugins/console/public/styles/_app.scss

-12
Original file line numberDiff line numberDiff line change
@@ -77,18 +77,6 @@
7777
z-index: $euiZLevel1;
7878
}
7979

80-
// SASSTODO: This component seems to not be used anymore?
81-
// Possibly replaced by the Ace version
82-
.conApp__autoComplete {
83-
position: absolute;
84-
left: -1000px;
85-
visibility: hidden;
86-
87-
/* by pass any other element in ace and resize bar, but not modal popups */
88-
z-index: $euiZLevel1 + 2;
89-
margin-top: 22px;
90-
}
91-
9280
.conApp__settingsModal {
9381
min-width: 460px;
9482
}

0 commit comments

Comments
 (0)