Bump node.js from v14.21.3 to v18.15.0

Revert "add node fiber to improve performance (#2319)"
Revert "[CVE-2022-25758] Use dart-sass instead of node-sass (#2054)"
Revert back to use node-sass and bump to 8.0.0
Change lmdb-store to lmdb
Bump node.js to 18 and fix errors

Issue Resolved:
#3601

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

Author: ananzh

.github/workflows/build_and_test_workflow.yml

@@ -102,6 +102,8 @@ jobs:
 
       - name: Run unit tests with coverage
         id: unit-tests
+        env:
+          NODE_OPTIONS: --max-old-space-size=8192
         run: yarn test:jest:ci:coverage
 
       - name: Run mocha tests with coverage

.node-version

@@ -1 +1 @@
-14.21.3
+18.15.0

.nvmrc

@@ -1 +1 @@
-14.21.3
+18.15.0

Dockerfile

@@ -1,4 +1,4 @@
-ARG NODE_VERSION=14.20.1
+ARG NODE_VERSION=18.15.0
 FROM node:${NODE_VERSION} AS base
 
 ENV HOME '.'

package.json

@@ -81,7 +81,7 @@
     "url": "https://github.com/opensearch-project/opensearch-dashboards.git"
   },
   "resolutions": {
-    "**/@types/node": "^14.17.32",
+    "**/@types/node": "18.11.18",
     "**/ansi-regex": "^5.0.1",
     "**/async": "^3.2.3",
     "**/d3-color": "^3.1.0",
@@ -166,7 +166,7 @@
     "deep-freeze-strict": "^1.1.1",
     "del": "^6.1.1",
     "dns-sync": "^0.2.1",
-    "elastic-apm-node": "^3.7.0",
+    "elastic-apm-node": "^3.43.0",
     "elasticsearch": "^16.7.0",
     "http-aws-es": "6.0.0",
     "execa": "^4.0.2",
@@ -301,7 +301,7 @@
     "@types/mock-fs": "^4.10.0",
     "@types/moment-timezone": "^0.5.12",
     "@types/mustache": "^0.8.31",
-    "@types/node": "^14.17.32",
+    "@types/node": "18.11.18",
     "@types/node-forge": "^1.0.1",
     "@types/normalize-path": "^3.0.0",
     "@types/pegjs": "^0.10.1",
@@ -468,7 +468,7 @@
     "zlib": "^1.0.5"
   },
   "engines": {
-    "node": "^14.20.1",
+    "node": "^18.15.0",
     "yarn": "^1.22.10"
   }
 }

packages/osd-config-schema/src/errors/__snapshots__/schema_error.test.ts.snap

@@ -5,7 +5,7 @@
 
 import path from 'path';
 import fs from 'fs';
-import { access, rmdir, mkdir, writeFile, symlink } from 'fs/promises';
+import { access, rm, mkdir, writeFile, symlink } from 'fs/promises';
 
 import {
   resolveToFullNameSync,
@@ -43,9 +43,9 @@ describe('Cross Platform', () => {
           try {
             // If leftover artifacts were found, get rid of them
             await access(tmpTestFolder);
-            await rmdir(tmpTestFolder, { recursive: true });
+            await rm(tmpTestFolder, { recursive: true });
           } catch (ex) {
-            // Do nothing; if `rmdir` failed, let the `mkdir` below throw the error
+            // Do nothing; if `rm` failed, let the `mkdir` below throw the error
           }
 
           await mkdir(tmpTestFolder);
@@ -60,7 +60,7 @@ describe('Cross Platform', () => {
 
         afterAll(async () => {
           try {
-            await rmdir(tmpTestFolder, { recursive: true });
+            await rm(tmpTestFolder, { recursive: true });
           } catch (ex) {
             // Do nothing
           }

packages/osd-cross-platform/src/path.test.ts

@@ -153,15 +153,15 @@ export function startProc(name: string, options: ProcOptions, log: ToolingLog) {
     await withTimeout(
       async () => {
         log.debug(`Sending "${signal}" to proc "${name}"`);
-        await treeKillAsync(childProcess.pid, signal);
+        await treeKillAsync(childProcess.pid!, signal);
         await outcomePromise;
       },
       STOP_TIMEOUT,
       async () => {
         log.warning(
           `Proc "${name}" was sent "${signal}" didn't emit the "exit" or "error" events after ${STOP_TIMEOUT} ms, sending SIGKILL`
         );
-        await treeKillAsync(childProcess.pid, 'SIGKILL');
+        await treeKillAsync(childProcess.pid!, 'SIGKILL');
       }
     );
 

packages/osd-dev-utils/src/proc_runner/proc.ts

@@ -27,7 +27,7 @@
     "del": "^6.1.1",
     "getopts": "^2.2.5",
     "pegjs": "0.10.0",
-    "sass-loader": "^10.2.0",
+    "sass-loader": "^10.4.1",
     "style-loader": "^1.1.3",
     "supports-color": "^7.0.0",
     "url-loader": "^2.2.0",

packages/osd-interpreter/package.json

@@ -25,16 +25,15 @@
     "dedent": "^0.7.0",
     "del": "^6.1.1",
     "execa": "^4.0.2",
-    "fibers": "^5.0.3",
     "jest-diff": "^27.5.1",
     "js-yaml": "^3.14.0",
     "json-stable-stringify": "^1.0.1",
-    "lmdb-store": "^1.6.11",
+    "lmdb": "^2.7.10",
+    "node-sass": "^8.0.0",
     "normalize-path": "^3.0.0",
     "pirates": "^4.0.1",
     "postcss": "^8.4.5",
     "rxjs": "^6.5.5",
-    "sass": "~1.26.11",
     "source-map-support": "^0.5.19",
     "terser-webpack-plugin": "^2.1.2",
     "tinymath": "1.2.1",
@@ -54,7 +53,7 @@
     "loader-utils": "^2.0.4",
     "postcss-loader": "^4.2.0",
     "raw-loader": "^4.0.2",
-    "sass-loader": "^10.2.0",
+    "sass-loader": "^10.4.1",
     "style-loader": "^1.1.3",
     "url-loader": "^2.2.0",
     "val-loader": "^2.1.2",

packages/osd-optimizer/package.json

@@ -52,6 +52,19 @@ const TMP_DIR = Path.resolve(__dirname, '../__fixtures__/__tmp__');
 const MOCK_REPO_SRC = Path.resolve(__dirname, '../__fixtures__/mock_repo');
 const MOCK_REPO_DIR = Path.resolve(TMP_DIR, 'mock_repo');
 
+jest.mock('lmdb', () => {
+  const mockedLmdb = {
+    open: jest.fn(() => ({
+      openDB: jest.fn(() => ({
+        get: jest.fn(),
+        putSync: jest.fn(),
+        remove: jest.fn(),
+      })),
+    })),
+  };
+  return mockedLmdb;
+});
+
 expect.addSnapshotSerializer({
   serialize: (value: string) => value.split(REPO_ROOT).join('<absolute path>').replace(/\\/g, '/'),
   test: (value: any) => typeof value === 'string' && value.includes(REPO_ROOT),

packages/osd-optimizer/src/integration_tests/__snapshots__/basic_optimization.test.ts.snap

@@ -32,7 +32,7 @@ import Path from 'path';
 import { Writable } from 'stream';
 
 import chalk from 'chalk';
-import * as LmdbStore from 'lmdb-store';
+import * as LmdbStore from 'lmdb';
 import { getMatchingRoot } from '@osd/cross-platform';
 
 const GLOBAL_ATIME = `${Date.now()}`;
@@ -96,8 +96,8 @@ export class Cache {
     // keys which haven't been used in 30 days. We use `unref()` to
     // make sure this timer doesn't hold other processes open
     // unexpectedly
-    this.timer = setTimeout(() => {
-      this.pruneOldKeys();
+    this.timer = setTimeout(async () => {
+      await this.pruneOldKeys();
     }, 30 * MINUTE);
 
     // timer.unref is not defined in jest which emulates the dom by default
@@ -134,12 +134,13 @@ export class Cache {
   async update(path: string, file: { mtime: string; code: string; map: any }) {
     const key = this.getKey(path);
 
-    await Promise.all([
-      this.safePut(this.atimes, key, GLOBAL_ATIME),
-      this.safePut(this.mtimes, key, file.mtime),
-      this.safePut(this.codes, key, file.code),
-      this.safePut(this.sourceMaps, key, JSON.stringify(file.map)),
-    ]);
+    this.safePut(this.atimes, key, GLOBAL_ATIME);
+    this.safePut(this.mtimes, key, file.mtime);
+    this.safePut(this.codes, key, file.code);
+
+    if (file.map != null) {
+      this.safePut(this.sourceMaps, key, JSON.stringify(file.map));
+    }
   }
 
   close() {
@@ -172,9 +173,9 @@ export class Cache {
     }
   }
 
-  private async safePut<V>(db: LmdbStore.Database<V, string>, key: string, value: V) {
+  private safePut<V>(db: LmdbStore.Database<V, string>, key: string, value: V) {
     try {
-      await db.put(key, value);
+      db.putSync(key, value);
       this.debug('PUT', db, key);
     } catch (error) {
       this.logError('PUT', db, key, error);
@@ -204,7 +205,6 @@ export class Cache {
       const validKeys: string[] = [];
       const invalidKeys: string[] = [];
 
-      // @ts-expect-error See https://github.com/DoctorEvidence/lmdb-store/pull/18
       for (const { key, value } of this.atimes.getRange()) {
         const atime = parseInt(`${value}`, 10);
         if (Number.isNaN(atime) || atime < ATIME_LIMIT) {

packages/osd-optimizer/src/integration_tests/basic_optimization.test.ts

@@ -89,6 +89,7 @@ function usingWorkerProc<T>(
             ? [`${inspectFlag}=${inspectPortCounter++}`]
             : []),
           ...(config.maxWorkerCount <= 3 ? ['--max-old-space-size=2048'] : []),
+          '--openssl-legacy-provider',
         ],
         buffer: false,
         stderr: 'pipe',