Skip to content

Commit e78e782

Browse files
committed
[Dashboards listing] fix listing limit
Initial page size was passed to the search function instead of the listing limit causing the max amount received to be significantly less than the previously implementation. Saved objects per page is `20` by default and the listing limit per page is `1000` by default. Issue: #4017 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
1 parent 6e352ff commit e78e782

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
254254
- [Console] Fix dev tool console autocomplete not loading issue ([#3775](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3775))
255255
- [Console] Fix dev tool console run command with query parameter error ([#3813](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3813))
256256
- Add clarifying tooltips to header navigation ([#3573](https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3573))
257+
- [Dashboards Listing] Fix listing limit to utilize `savedObjects:listingLimit` instead of `savedObjects:perPage` ([#4021](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4021))
257258

258259
### 🚞 Infrastructure
259260

src/plugins/dashboard/public/application/legacy_app.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ export function initDashboardApp(app, deps) {
150150
type: $scope.dashboardListTypes,
151151
search: search ? `${search}*` : undefined,
152152
fields: ['title', 'type', 'description', 'updated_at'],
153-
perPage: $scope.initialPageSize,
153+
perPage: $scope.listingLimit,
154154
page: 1,
155155
searchFields: ['title^3', 'type', 'description'],
156156
defaultSearchOperator: 'AND',

0 commit comments

Comments
 (0)