Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isMaster usage once drop support for Node.js version 14 #4131

Open
ananzh opened this issue May 24, 2023 · 0 comments
Open

Remove isMaster usage once drop support for Node.js version 14 #4131

ananzh opened this issue May 24, 2023 · 0 comments
Labels
NODE 18 ⚙ technical debt If not paid, jeapardizes long-term success and maintainability of the repository.

Comments

@ananzh
Copy link
Member

ananzh commented May 24, 2023

Description

In our codebase, we have a TODO note indicating that we're using the cluster.isMaster property for Node.js 14 support and the cluster.isPrimary property for Node.js 18+.

Here's the specific line of code:

// ToDo: `isMaster` is a Node 14- prop; remove it when Node 18+ is the only engine supported
const isClusterManager = cluster.isPrimary ?? cluster.isMaster;

This issue tracks the removal of cluster.isMaster once we drop support for Node.js version 14.

@joshuarrrr joshuarrrr added technical debt If not paid, jeapardizes long-term success and maintainability of the repository. and removed untriaged labels May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NODE 18 ⚙ technical debt If not paid, jeapardizes long-term success and maintainability of the repository.
Projects
None yet
Development

No branches or pull requests

2 participants