Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common-utils from external repo into OpenSearch #2545

Open
dblock opened this issue Mar 21, 2022 · 2 comments
Open

Move common-utils from external repo into OpenSearch #2545

dblock opened this issue Mar 21, 2022 · 2 comments
Labels
enhancement Enhancement or improvement to existing feature or request

Comments

@dblock
Copy link
Member

dblock commented Mar 21, 2022

Is your feature request related to a problem? Please describe.
Coming from opensearch-project/common-utils#114, move common-utils into OpenSearch.

@dblock dblock added enhancement Enhancement or improvement to existing feature or request untriaged labels Mar 21, 2022
@nknize
Copy link
Collaborator

nknize commented Mar 23, 2022

👎 for 2.0.0 it won't be ready:

  1. There is a lot of legacy code that should be removed before refactoring to core
  2. There is kotlin code that we need to tie in w/ the build hooks
  3. The Integration Tests are Disabled w/ a note "Enable this after integration with security plugin is done" So why aren't we just integrating the appropriate classes with the security plugin?
  4. There is no bwc integration tests and that will take some time to work out in core.

👍 for a future release if targeting core makes sense. We might want to integrate with security first (or dissolve the implementations across other plugins) then integrate security with core rather than blindly integrate with core.

@lezzago
Copy link
Member

lezzago commented Feb 22, 2023

Regarding the integration tests for common-utils. I believe it does not make sense to have any integration tests for the package since the only way to create one is for plugins that depend on the package to create integration tests to test different functionality such as ensuring the Alerting plugin can make calls to the Notification plugin through the data models available in the common-utils package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

No branches or pull requests

4 participants