Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] enhance the rest predict API to put all logic behind transport call #3651

Open
jngz-es opened this issue Mar 14, 2025 · 0 comments
Assignees
Labels

Comments

@jngz-es
Copy link
Collaborator

jngz-es commented Mar 14, 2025

Description

Recently we got a security test case failure for testPredictWithReadOnlyMLAccess that is caused by the pr #3597. Basically we have model index reading before transport call in which there is a cluster permission control. So in that test case, we failed to hit the no permission error instead we got an index reading error. This is not correct, we should check the permission at the beginning.

Solution

Move model index reading from rest layer to transport layer.

@jngz-es jngz-es self-assigned this Mar 14, 2025
@jngz-es jngz-es removed the untriaged label Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants