Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Release issue is incorrect in the metrics data #123

Closed
gaiksaya opened this issue Mar 12, 2025 · 1 comment · Fixed by #125
Closed

[BUG] Release issue is incorrect in the metrics data #123

gaiksaya opened this issue Mar 12, 2025 · 1 comment · Fixed by #125
Assignees
Labels
bug Something isn't working

Comments

@gaiksaya
Copy link
Member

gaiksaya commented Mar 12, 2025

What is the bug?

The release issue for opensearch-build repo has incorrect values(s)

How can one reproduce the bug?

  1. Go to metrics.opensearch.org
  2. Go to dev-tools
  3. Try below query:
GET opensearch_release_metrics/_search
{
    "size": 20, 
    "query": {
        "bool": {
            "filter": [
                {
                    "match_phrase": {
                        "version": "3.0.0"
                    }
                },
                {
                    "match_phrase": {
                        "repository": "opensearch-build"
                    }
                }
            ]
        }
    }
}

Check the release_issue value in returned documents. It responds with

      {
        "_index": "opensearch_release_metrics",
        "_id": "d76000bb-41cb-31ff-99da-d5b6c6ffc83b",
        "_score": null,
        "_source": {
          "release_issue_exists": true,
          "release_notes": false,
          "version_increment": false,
          "release_issue": "https://github.com/opensearch-project/opensearch-build/issues/1911",
          "autocut_issues_open": 0,
          "repository": "opensearch-build",
          "release_state": "open",
          "version": "3.0.0",
          "pulls_open": 0,
          "release_owner_exists": true,
          "current_date": "2025-03-12T18:25:20.844380018",
          "component": "opensearch-build",
          "release_branch": false,
          "issues_closed": 9,
          "pulls_closed": 31,
          "id": "d76000bb-41cb-31ff-99da-d5b6c6ffc83b",
          "issues_open": 12,
          "release_version": "3.0.0",
          "release_owners": [
            "peterzhuamazon",
            "zelinh"
          ]
        },
        "sort": [
          1741803920844
        ]
      },

Everything apart from release_issue seems okay.

What is the expected behavior?

Value should be opensearch-project/opensearch-build#3747 instead of opensearch-project/opensearch-build#3784

What is your host/environment?

Operating system, version.

Do you have any screenshots?

If applicable, add screenshots to help explain your problem.

Do you have any additional context?

Add any other context about the problem.

@gaiksaya gaiksaya added bug Something isn't working untriaged Issues that have not yet been triaged labels Mar 12, 2025
@gaiksaya
Copy link
Member Author

The release issue should grab the latest (newest) issue everytime if multiple issues are found with same query.

Possible code changes need to go in https://github.com/opensearch-project/opensearch-metrics/blob/main/src/main/java/org/opensearchmetrics/metrics/release/ReleaseIssueChecker.java#L51-L67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant