-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Support register_model with a dict parameter model_config #390
Comments
Hello @yuye-aws, wanted to clarify something on this feature. I checked the register model method and when the model is uploaded there is a check against the mandatory fields - a dict parameter such as model_config doesn't contain all the necessary parameters i.e. name, version, format in comparison to current implementation of a json file with all the metadata. So, are you suggesting there should be an alternate parameter for a dict which contains all the mandatory parameters along with the model config dict (guessing this would be a nested dict)? |
@yuye-aws could you please clarify your question further? |
Exactly yes. When calling |
Is your feature request related to a problem?
The
register_model
method inml_commons_client.py
only acceptsmodel_config_path
as the input for model_config.What solution would you like?
A clear and concise description of what you want to happen.
The
register_model
method can also take in a dict parameter such asmodel_config
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: