Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description (and other metadata like Title) must not contain escaped characters #2164

Open
kelson42 opened this issue Feb 16, 2025 · 6 comments

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Feb 16, 2025

D&D description is not correct, see below

@kelson42 cloned issue kiwix/kiwix-android#4087 on 2024-11-17:

Screenshot:
Image

@kelson42
Copy link
Collaborator Author

@kelson42 commented on 2024-11-19:

Probably a problem with MWoffliner

@kelson42
Copy link
Collaborator Author

@MohitMaliFtechiz commented on 2024-11-27:

@kelson42 I don't know if it is an MWoffiner problem or not as the description has the HTML entry in it. But It is a Kiwix app problem the description is "D&D Wiki" which has the HTML entry. But Kiwix is not properly decoding the HTML entries before setting it to the textView. I have fixed this issue in kiwix/kiwix-android#4111.

@kelson42
Copy link
Collaborator Author

@kelson42 commented on 2024-11-27:

@MohitMaliFtechiz Why should Kiwix decode HTML there? If someone put a png there, you want also to decode the png?

@kelson42
Copy link
Collaborator Author

@MohitMaliFtechiz commented on 2024-11-28:

@kelson42 No, we don't want to decode the png in the Kiwix. The problem is on MWoffliner as it is puting the HTML in the description, but at least Kiwix should decode the HTML for the title and description if any comes due to this type of bug to avoid this type of visual error.

@kelson42
Copy link
Collaborator Author

@kelson42 commented on 2024-11-28:

@MohitMaliFtechiz No, bug should be fixed at the right place. Fixing problems at the wrong place is the best way to create strange behaviours in edge cases and future bugs.

@benoit74 benoit74 changed the title D&D description is not displayed correctly Description (and other metadata like Title) should not contain escaped characters Feb 16, 2025
@benoit74 benoit74 changed the title Description (and other metadata like Title) should not contain escaped characters Description (and other metadata like Title) must not contain escaped characters Feb 16, 2025
@benoit74
Copy link
Contributor

Note that in the mean time (until this issue get fixed) this ZIM title has been fixed manually (i.e. set as recipe argument). Do not consider that the fact it is now OK in the ZIM means that issue is gone, issue still needs to be fixed. We probably need to unescape the title which is retrieved from Mediawiki metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants