Merge pull request #2602 from opossum-tool/fix-zero-sized-element-in-virtualized-list

fix: zero-sized element in virtualized list

Author: mstykow

src/Frontend/Components/AttributionPanels/AttributionsPanel/LinkButton/LinkButton.tsx

@@ -34,6 +34,7 @@ export const LinkButton: React.FC<PackagesPanelChildrenProps> = ({
       aria-label={text.packageLists.linkAsAttribution}
       disabled={
         isSelectedResourceBreakpoint ||
+        !selectedAttributionIds.length ||
         isPackageInfoModified ||
         activeRelation === 'resource' ||
         !!attributionIdsForReplacement.length

src/Frontend/Components/ConfirmDeletePopup/ConfirmDeletePopup.tsx

@@ -117,9 +117,9 @@ export const ConfirmDeletePopup: React.FC<Props> = ({
           })}
         </MuiTypography>
         <CardList
-          data={attributionIdsToDelete}
+          data={attributionIdsToDelete.filter((id) => id in attributions)}
           renderItemContent={(attributionId, { index }) => {
-            if (!attributionId || !(attributionId in attributions)) {
+            if (!attributions[attributionId]) {
               return null;
             }
 

src/Frontend/Components/ConfirmReplacePopup/ConfirmReplacePopup.tsx

@@ -96,10 +96,10 @@ export const ConfirmReplacePopup = ({
           )}
         </MuiTypography>
         <CardList
-          data={attributionIdsForReplacement}
+          data={attributionIdsForReplacement.filter((id) => id in attributions)}
           data-testid={'removed-attributions'}
           renderItemContent={(attributionId, { index }) => {
-            if (!attributionId || !(attributionId in attributions)) {
+            if (!attributions[attributionId]) {
               return null;
             }
 

src/Frontend/Components/ConfirmSavePopup/ConfirmSavePopup.tsx

@@ -146,9 +146,9 @@ export const ConfirmSavePopup: React.FC<Props> = ({
           })}
         </MuiTypography>
         <CardList
-          data={attributionIdsToSave}
+          data={attributionIdsToSave.filter((id) => id in attributions)}
           renderItemContent={(attributionId, { index }) => {
-            if (!attributionId || !(attributionId in attributions)) {
+            if (!attributions[attributionId]) {
               return null;
             }