Unit test linking and unlinking attributions

Signed-off-by: Markus Obendrauf <markusobendrauf@fb.com>

Author: MarkusObendrauf

src/Frontend/state/helpers/__tests__/save-action-helpers.test.ts

@@ -19,6 +19,8 @@ import {
   createManualAttribution,
   deleteManualAttribution,
   updateManualAttribution,
+  unlinkResourceFromAttributionId,
+  linkToAttributionManualData,
 } from '../save-action-helpers';
 
 const testUuid: string = uuidNil;
@@ -91,24 +93,19 @@ describe('The deleteManualAttribution function', () => {
   });
 
   it('correctly maintains childrenFromAttributedResources', () => {
-    const testAnotherUuid = '000';
     const testManualData: AttributionData = {
       attributions: {
-        [testAnotherUuid]: {
-          packageName: 'another testpackage',
-        },
         [testUuid]: {
           packageName: 'testpackage',
           packageVersion: '2.0',
           licenseText: 'Permission is hereby granted',
         },
       },
       resourcesToAttributions: {
-        '/first/': [testUuid, testAnotherUuid],
+        '/first/': [testUuid],
       },
       attributionsToResources: {
         [testUuid]: ['/first/'],
-        [testAnotherUuid]: ['/first/'],
       },
       resourcesWithAttributedChildren: {
         attributedChildren: {
@@ -126,19 +123,11 @@ describe('The deleteManualAttribution function', () => {
       testUuid,
       () => false,
     );
-    expect(newManualData.attributions).toEqual({
-      '000': { packageName: 'another testpackage' },
-    });
-    expect(newManualData.resourcesToAttributions).toEqual({
-      '/first/': ['000'],
-    });
-    expect(newManualData.attributionsToResources).toEqual({
-      '000': ['/first/'],
-    });
+    expect(newManualData.attributions).toEqual({});
+    expect(newManualData.resourcesToAttributions).toEqual({});
+    expect(newManualData.attributionsToResources).toEqual({});
     expect(newManualData.resourcesWithAttributedChildren).toEqual({
-      attributedChildren: {
-        '0': new Set<number>().add(1),
-      },
+      attributedChildren: {},
       pathsToIndices: {
         '/': 0,
         '/first/': 1,
@@ -193,6 +182,190 @@ describe('The updateManualAttribution function', () => {
   });
 });
 
+describe('The linkToAttributionManualData function', () => {
+  it('links a manual attribution', () => {
+    const testAnotherUuid = '000';
+    const testManualData: AttributionData = {
+      attributions: {
+        [testAnotherUuid]: {
+          packageName: 'another testpackage',
+        },
+        [testUuid]: {
+          packageName: 'testpackage',
+          packageVersion: '2.0',
+          licenseText: 'Permission is hereby granted',
+        },
+      },
+      resourcesToAttributions: {
+        '/first/': [testAnotherUuid],
+      },
+      attributionsToResources: {
+        [testAnotherUuid]: ['/first/'],
+      },
+      resourcesWithAttributedChildren: {
+        attributedChildren: {
+          '0': new Set<number>().add(1),
+        },
+        pathsToIndices: {
+          '/': 0,
+          '/first/': 1,
+        },
+        paths: ['/', '/first/'],
+      },
+    };
+
+    const newManualData = linkToAttributionManualData(
+      testManualData,
+      '/first/',
+      testUuid,
+      () => false,
+    );
+
+    expect(newManualData.attributions).toEqual(testManualData.attributions);
+    expect(newManualData.resourcesToAttributions).toEqual({
+      '/first/': [testAnotherUuid, testUuid],
+    });
+    expect(newManualData.attributionsToResources).toEqual({
+      [testUuid]: ['/first/'],
+      [testAnotherUuid]: ['/first/'],
+    });
+    expect(newManualData.resourcesWithAttributedChildren).toEqual(
+      testManualData.resourcesWithAttributedChildren,
+    );
+  });
+
+  it('correctly maintains childrenFromAttributedResources', () => {
+    const testManualData: AttributionData = {
+      attributions: {
+        [testUuid]: {
+          packageName: 'testpackage',
+          packageVersion: '2.0',
+          licenseText: 'Permission is hereby granted',
+        },
+      },
+      resourcesToAttributions: {},
+      attributionsToResources: {},
+      resourcesWithAttributedChildren: {
+        attributedChildren: {},
+        pathsToIndices: {
+          '/': 0,
+          '/first/': 1,
+        },
+        paths: ['/', '/first/'],
+      },
+    };
+
+    const newManualData = linkToAttributionManualData(
+      testManualData,
+      '/first/',
+      testUuid,
+      () => false,
+    );
+
+    expect(newManualData.resourcesWithAttributedChildren).toEqual({
+      attributedChildren: {
+        '0': new Set<number>().add(1),
+      },
+      pathsToIndices: {
+        '/': 0,
+        '/first/': 1,
+      },
+      paths: ['/', '/first/'],
+    });
+  });
+});
+
+describe('The unlinkResourceFromAttributionId function', () => {
+  it('unlinks a manual attribution', () => {
+    const testManualData: AttributionData = {
+      attributions: {
+        [testUuid]: {
+          packageName: 'testpackage',
+          packageVersion: '2.0',
+          licenseText: 'Permission is hereby granted',
+        },
+      },
+      resourcesToAttributions: {
+        '/first/': [testUuid],
+      },
+      attributionsToResources: {
+        [testUuid]: ['/first/'],
+      },
+      resourcesWithAttributedChildren: {
+        attributedChildren: {
+          '0': new Set<number>().add(1),
+        },
+        pathsToIndices: {
+          '/': 0,
+          '/first/': 1,
+        },
+        paths: ['/', '/first/'],
+      },
+    };
+
+    const newManualData: AttributionData = unlinkResourceFromAttributionId(
+      testManualData,
+      '/first/',
+      testUuid,
+    );
+
+    expect(newManualData.attributions).toEqual(testManualData.attributions);
+    expect(isEmpty(newManualData.resourcesToAttributions)).toBe(true);
+    expect(isEmpty(newManualData.attributionsToResources)).toBe(true);
+    expect(newManualData.resourcesWithAttributedChildren).toEqual({
+      attributedChildren: {},
+      pathsToIndices: {
+        '/': 0,
+        '/first/': 1,
+      },
+      paths: ['/', '/first/'],
+    });
+  });
+
+  it('correctly maintains childrenFromAttributedResources', () => {
+    const testManualData: AttributionData = {
+      attributions: {
+        [testUuid]: {
+          packageName: 'testpackage',
+          packageVersion: '2.0',
+          licenseText: 'Permission is hereby granted',
+        },
+      },
+      resourcesToAttributions: {
+        '/first/': [testUuid],
+      },
+      attributionsToResources: {
+        [testUuid]: ['/first/'],
+      },
+      resourcesWithAttributedChildren: {
+        attributedChildren: {
+          '0': new Set<number>().add(1),
+        },
+        pathsToIndices: {
+          '/': 0,
+          '/first/': 1,
+        },
+        paths: ['/', '/first/'],
+      },
+    };
+
+    const newManualData: AttributionData = unlinkResourceFromAttributionId(
+      testManualData,
+      '/first/',
+      testUuid,
+    );
+
+    expect(newManualData.resourcesWithAttributedChildren).toEqual({
+      attributedChildren: {},
+      pathsToIndices: {
+        '/': 0,
+        '/first/': 1,
+      },
+      paths: ['/', '/first/'],
+    });
+  });
+});
+
 describe('_removeManualAttributionFromChildrenIfAllAreIdentical', () => {
   it('three matching', () => {
     const testManualData: AttributionData = {