fix: discard-and-proceed not working when creating new attribution

mstykow · mstykow · commit 72618afd5624 · 2024-05-17T17:59:27.000+02:00
- adjust check setting the selected attribution to distinguish between null and empty string Fixes #2635 Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
diff --git a/src/Frontend/state/actions/resource-actions/navigation-actions.ts b/src/Frontend/state/actions/resource-actions/navigation-actions.ts
@@ -36,12 +36,12 @@ export function setSelectedResourceOrAttributionIdToTargetValue(): AppThunkActio
     const targetSelectedAttributionId =
       getTargetSelectedAttributionId(getState());
 
-    if (targetSelectedResourceId) {
+    if (targetSelectedResourceId !== null) {
       dispatch(setSelectedResourceId(targetSelectedResourceId));
       dispatch(setTargetSelectedResourceId(null));
     }
 
-    if (targetSelectedAttributionId) {
+    if (targetSelectedAttributionId !== null) {
       dispatch(setSelectedAttributionId(targetSelectedAttributionId));
       dispatch(setTargetSelectedAttributionId(null));
     }

Original file line number	Diff line number	Diff line change
`@@ -36,12 +36,12 @@ export function setSelectedResourceOrAttributionIdToTargetValue(): AppThunkActio`
`36`	`36`	`const targetSelectedAttributionId =`
`37`	`37`	`getTargetSelectedAttributionId(getState());`
`38`	`38`
`39`		`- if (targetSelectedResourceId) {`
	`39`	`+ if (targetSelectedResourceId !== null) {`
`40`	`40`	`dispatch(setSelectedResourceId(targetSelectedResourceId));`
`41`	`41`	`dispatch(setTargetSelectedResourceId(null));`
`42`	`42`	`}`
`43`	`43`
`44`		`- if (targetSelectedAttributionId) {`
	`44`	`+ if (targetSelectedAttributionId !== null) {`
`45`	`45`	`dispatch(setSelectedAttributionId(targetSelectedAttributionId));`
`46`	`46`	`dispatch(setTargetSelectedAttributionId(null));`
`47`	`47`	`}`