Skip to content

Commit 9c005ad

Browse files
committed
fix: autocomplete end-icon click opens popover
- stop propagation of mouse-down and click events on end-adornment container Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
1 parent 0e7cfd6 commit 9c005ad

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/Frontend/Components/Autocomplete/Autocomplete.tsx

+4-2
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,10 @@ export function Autocomplete<
225225
}
226226

227227
return (
228-
<EndAdornmentContainer>
228+
<EndAdornmentContainer
229+
onClick={(event) => event.stopPropagation()}
230+
onMouseDown={(event) => event.stopPropagation()}
231+
>
229232
{hasClearButton && (
230233
<ClearButton
231234
{...(getClearProps() as MuiIconButtonProps)}
@@ -236,7 +239,6 @@ export function Autocomplete<
236239
<PopupIndicator
237240
popupOpen={isPopupOpen}
238241
{...(getPopupIndicatorProps() as MuiIconButtonProps)}
239-
onClick={undefined}
240242
/>
241243
)}
242244
{endAdornment}

src/Frontend/Components/IconButton/IconButton.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ interface IconButtonProps {
1313
tooltipPlacement?: TooltipProps['placement'];
1414
iconSx?: SxProps;
1515
containerSx?: SxProps;
16-
onClick?(): void;
16+
onClick: React.MouseEventHandler<HTMLButtonElement> | undefined;
1717
icon: ReactElement;
1818
disabled?: boolean;
1919
hidden?: boolean;
@@ -39,7 +39,7 @@ export function IconButton(props: IconButtonProps) {
3939
sx={props.iconSx}
4040
onClick={(event) => {
4141
event.stopPropagation();
42-
props.onClick?.();
42+
props.onClick?.(event);
4343
}}
4444
disabled={props.disabled}
4545
data-testid={props['data-testid']}

0 commit comments

Comments
 (0)