Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit b8b2d3d

Browse files
committedMar 12, 2025··
fix: post-rebase cleanup
1 parent 8291a69 commit b8b2d3d

File tree

11 files changed

+22
-21
lines changed

11 files changed

+22
-21
lines changed
 

‎src/ElectronBackend/input/__tests__/refineConfiguration.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { EMPTY_PROJECT_CONFIG } from '../../../Frontend/shared-constants';
66
import {
77
Attributions,
88
PackageInfo,
9-
RawClassifications,
9+
RawClassificationsConfig,
1010
RawProjectConfig,
1111
} from '../../../shared/shared-types';
1212
import { faker } from '../../../testing/Faker';
@@ -29,7 +29,7 @@ function fakePackagesWithClassifications(
2929
function fakeConfigWithClassificationIds(
3030
...classificationIds: Array<number>
3131
): RawProjectConfig {
32-
const classifications: RawClassifications = {};
32+
const classifications: RawClassificationsConfig = {};
3333
classificationIds.forEach((classificationId) => {
3434
classifications[classificationId] = faker.word.words();
3535
});

‎src/ElectronBackend/input/refineConfiguration.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ import { EMPTY_RAW_PROJECT_CONFIG } from '../../Frontend/shared-constants';
66
import {
77
Attributions,
88
PackageInfo,
9-
RawClassifications,
9+
RawClassificationsConfig,
1010
RawProjectConfig,
1111
} from '../../shared/shared-types';
1212
import logger from '../main/logger';
1313

1414
function addUnconfiguredClassifications(
15-
classifications: RawClassifications,
15+
classifications: RawClassificationsConfig,
1616
externalAttributions: Attributions,
1717
) {
1818
const configuredAttributionKeys = Object.keys(classifications).map(Number);

‎src/Frontend/Components/AttributionCountPerSourcePerLicenseTable/AttributionCountPerSourcePerLicenseTableRow/AttributionCountPerSourcePerLicenseTableRow.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,8 @@ const RowCellContent: React.FC<RowCellContentProps> = (props) => {
9494
);
9595
} else if (props.column.columnType === SingleColumn.CLASSIFICATION) {
9696
return props.licenseClassification
97-
? (classifications[props.licenseClassification] ?? componentText.none)
97+
? (classifications[props.licenseClassification]?.description ??
98+
componentText.none)
9899
: componentText.none;
99100
} else if (props.column.columnType === SingleColumn.TOTAL) {
100101
return props.totalSignalCount;

‎src/Frontend/Components/AttributionForm/AuditingOptions/AuditingOptions.util.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ export function useAuditingOptions({
225225
<ClassificationIcon
226226
noTooltip
227227
classification={packageInfo.classification}
228-
classification_mapping={classifications}
228+
classificationsConfig={classifications}
229229
/>
230230
),
231231
selected: !!packageInfo.classification,

‎src/Frontend/Components/ProjectStatisticsPopup/ProjectStatisticsPopup.util.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ export function getSignalCountByClassification(
357357
const pieChartData = Object.keys(classifications)
358358
.map(Number)
359359
.map<ChartDataItem>((classification) => {
360-
const classificationName = classifications[classification];
360+
const classificationName = classifications[classification].description;
361361
const classificationCount =
362362
classificationCounts[toNumber(classification)] ?? 0;
363363

‎src/Frontend/state/actions/resource-actions/load-actions.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ import chroma from 'chroma-js';
66

77
import {
88
ClassificationEntry,
9-
Classifications,
9+
ClassificationsConfig,
1010
ParsedFileContent,
1111
ProjectConfig,
12-
RawClassifications,
12+
RawClassificationsConfig,
1313
RawProjectConfig,
1414
} from '../../../../shared/shared-types';
1515
import { OpossumColors } from '../../../shared-styles';
@@ -42,7 +42,7 @@ function interpolateBetweenRedAndWhite(
4242

4343
function getClassificationColor(
4444
classificationId: string,
45-
classifications: RawClassifications,
45+
classifications: RawClassificationsConfig,
4646
) {
4747
const configuredClassificationIds = Object.keys(classifications).toReversed();
4848
const numberOfClassifications = configuredClassificationIds.length;
@@ -55,7 +55,7 @@ function getClassificationColor(
5555
function addColorsToClassifications(
5656
rawProjectConfig: RawProjectConfig,
5757
): ProjectConfig {
58-
const classifications: Classifications =
58+
const classifications: ClassificationsConfig =
5959
Object.fromEntries<ClassificationEntry>(
6060
Object.entries(rawProjectConfig.classifications).map(
6161
([classificationId, classificationEntry]) => {

‎src/Frontend/state/helpers/progress-bar-data-helpers.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// SPDX-License-Identifier: Apache-2.0
55
import {
66
Attributions,
7-
Classifications,
7+
ClassificationsConfig,
88
Criticality,
99
Resources,
1010
ResourcesToAttributions,
@@ -265,7 +265,7 @@ export function getUpdatedProgressBarData(args: {
265265
resolvedExternalAttributions: Set<string>;
266266
attributionBreakpoints: Set<string>;
267267
filesWithChildren: Set<string>;
268-
classifications: Classifications;
268+
classifications: ClassificationsConfig;
269269
}): ProgressBarData {
270270
const progressBarData = getEmptyProgressBarData(args.classifications);
271271

@@ -287,7 +287,7 @@ export function getUpdatedProgressBarData(args: {
287287
}
288288

289289
export function getEmptyProgressBarData(
290-
classifications: Classifications,
290+
classifications: ClassificationsConfig,
291291
): ProgressBarData {
292292
const classificationStatistics: ClassificationStatistics = {};
293293
if (classifications) {

‎src/Frontend/test-helpers/general-test-helpers.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
AttributionsToResources,
1111
ExternalAttributionSources,
1212
ParsedFileContent,
13-
ProjectConfig,
13+
RawProjectConfig,
1414
Resources,
1515
ResourcesToAttributions,
1616
} from '../../shared/shared-types';
@@ -45,7 +45,7 @@ const EMPTY_PARSED_FILE_CONTENT: ParsedFileContent = {
4545

4646
export function getParsedInputFileEnrichedWithTestData(testData: {
4747
resources?: Resources;
48-
config?: ProjectConfig;
48+
config?: RawProjectConfig;
4949
manualAttributions?: Attributions;
5050
resourcesToManualAttributions?: ResourcesToAttributions;
5151
externalAttributions?: Attributions;

‎src/Frontend/web-workers/scripts/get-progress-data.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// SPDX-License-Identifier: Apache-2.0
55
import {
66
AttributionData,
7-
Classifications,
7+
ClassificationsConfig,
88
Resources,
99
} from '../../../shared/shared-types';
1010
import { getUpdatedProgressBarData } from '../../state/helpers/progress-bar-data-helpers';
@@ -17,7 +17,7 @@ interface Props {
1717
manualData: AttributionData;
1818
resolvedExternalAttributions: Set<string>;
1919
resources: Resources;
20-
classifications: Classifications;
20+
classifications: ClassificationsConfig;
2121
}
2222

2323
export function getProgressData({

‎src/Frontend/web-workers/signals-worker.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import {
66
AttributionData,
77
Attributions,
8-
Classifications,
8+
ClassificationsConfig,
99
Resources,
1010
} from '../../shared/shared-types';
1111
import { text } from '../../shared/text';
@@ -85,7 +85,7 @@ interface State {
8585
signalSearch?: string;
8686
signalSelectedLicense?: string;
8787
signalSorting?: Sorting;
88-
classifications?: Classifications;
88+
classifications?: ClassificationsConfig;
8989
}
9090

9191
export type SignalsWorkerInput = Unionize<State>;

‎src/shared/shared-types.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ export interface ClassificationEntry {
157157

158158
export type ClassificationsConfig = Record<Classification, ClassificationEntry>;
159159

160-
export type RawClassificationsConfig = Record<Classification, string>
160+
export type RawClassificationsConfig = Record<Classification, string>;
161161

162162
export interface ProjectConfig {
163163
classifications: ClassificationsConfig;

0 commit comments

Comments
 (0)
Please sign in to comment.