Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oximeter: rework try_force_collect() #7673

Open
jgallagher opened this issue Feb 27, 2025 · 0 comments
Open

oximeter: rework try_force_collect() #7673

jgallagher opened this issue Feb 27, 2025 · 0 comments

Comments

@jgallagher
Copy link
Contributor

On a call today with @bnaecker and @andrewjstone discussing single-node / multi-node clickhouse, we found that the current implementation of try_force_collect() for tests is a pretty big hindrance to moving to a "both single-node and multi-node clickhouse running" world (which is where we want to be!).

The proposal we discussed was to make it a fire-and-forget action instead of the current implementation where it waits for a collection to be made. This may require reworking some tests to retry queries, but there's a reasonable chance those tests might need the same kind of rework to support querying a multi-node clickhouse in the future anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant