Require output flag for pack

Author: emily.johnson

cargo/jam/commands/pack.go

@@ -22,7 +22,7 @@ type packFlags struct {
 }
 
 func pack() *cobra.Command {
-	flags :=&packFlags{}
+	flags := &packFlags{}
 	cmd := &cobra.Command{
 		Use:   "pack",
 		Short: "package buildpack",
@@ -40,6 +40,10 @@ func pack() *cobra.Command {
 	if err != nil {
 		fmt.Fprintf(os.Stderr, "Unable to mark buildpack flag as required")
 	}
+	err = cmd.MarkFlagRequired("output")
+	if err != nil {
+		fmt.Fprintf(os.Stderr, "Unable to mark output flag as required")
+	}
 	err = cmd.MarkFlagRequired("version")
 	if err != nil {
 		fmt.Fprintf(os.Stderr, "Unable to mark version flag as required")

cargo/jam/pack_test.go

@@ -46,6 +46,7 @@ func testPack(t *testing.T, context spec.G, it spec.S) {
 		Expect(os.RemoveAll(tmpDir)).To(Succeed())
 		Expect(os.RemoveAll(buildpackDir)).To(Succeed())
 	})
+
 	context("when packaging a language family buildpack", func() {
 
 		it.Before(func() {
@@ -331,17 +332,68 @@ func testPack(t *testing.T, context spec.G, it spec.S) {
 				Expect(hdr.Mode).To(Equal(int64(0644)))
 			})
 		})
+	})
+
+	context("failure cases", func() {
+		context("when the all the required flags are not set", func() {
+			it("prints an error message", func() {
+				command := exec.Command(path, "pack")
+				session, err := gexec.Start(command, buffer, buffer)
+				Expect(err).NotTo(HaveOccurred())
+				Eventually(session).Should(gexec.Exit(1), func() string { return buffer.String() })
+
+				Expect(session.Err.Contents()).To(ContainSubstring("Error: required flag(s) \"buildpack\", \"output\", \"version\" not set"))
+			})
+		})
+
+		context("when the required buildpack flag is not set", func() {
+			it("prints an error message", func() {
+				command := exec.Command(
+					path, "pack",
+					"--output", filepath.Join(tmpDir, "output.tgz"),
+					"--version", "some-version",
+					"--offline",
+					"--stack", "io.buildpacks.stacks.bionic",
+				)
+				session, err := gexec.Start(command, buffer, buffer)
+				Expect(err).NotTo(HaveOccurred())
+				Eventually(session).Should(gexec.Exit(1), func() string { return buffer.String() })
+
+				Expect(session.Err.Contents()).To(ContainSubstring("Error: required flag(s) \"buildpack\" not set"))
+			})
+		})
 
-		context("failure cases", func() {
-			context("when the --buildpack flag is empty", func() {
-				it("prints an error message", func() {
-					command := exec.Command(path, "pack")
-					session, err := gexec.Start(command, buffer, buffer)
-					Expect(err).NotTo(HaveOccurred())
-					Eventually(session).Should(gexec.Exit(1), func() string { return buffer.String() })
+		context("when the required output flag is not set", func() {
+			it("prints an error message", func() {
+				command := exec.Command(
+					path, "pack",
+					"--buildpack", filepath.Join(buildpackDir, "buildpack.toml"),
+					"--version", "some-version",
+					"--offline",
+					"--stack", "io.buildpacks.stacks.bionic",
+				)
+				session, err := gexec.Start(command, buffer, buffer)
+				Expect(err).NotTo(HaveOccurred())
+				Eventually(session).Should(gexec.Exit(1), func() string { return buffer.String() })
+
+				Expect(session.Err.Contents()).To(ContainSubstring("Error: required flag(s) \"output\" not set"))
+			})
+		})
+
+		context("when the required version flag is not set", func() {
+			it("prints an error message", func() {
+				command := exec.Command(
+					path, "pack",
+					"--buildpack", filepath.Join(buildpackDir, "buildpack.toml"),
+					"--output", filepath.Join(tmpDir, "output.tgz"),
+					"--offline",
+					"--stack", "io.buildpacks.stacks.bionic",
+				)
+				session, err := gexec.Start(command, buffer, buffer)
+				Expect(err).NotTo(HaveOccurred())
+				Eventually(session).Should(gexec.Exit(1), func() string { return buffer.String() })
 
-					Expect(session.Err.Contents()).To(ContainSubstring("Error: required flag(s) \"buildpack\", \"version\" not set"))
-				})
+				Expect(session.Err.Contents()).To(ContainSubstring("Error: required flag(s) \"version\" not set"))
 			})
 		})
 	})

cargo/jam/summarize_test.go

@@ -431,4 +431,20 @@ version = "3.4.5"
 			}`))
 		})
 	})
+
+	context.Focus("failure cases", func() {
+		context("when the required buildpack flag is not set", func() {
+			it("prints an error message", func() {
+				command := exec.Command(
+					path, "summarize",
+					"--format", "markdown",
+				)
+				session, err := gexec.Start(command, buffer, buffer)
+				Expect(err).NotTo(HaveOccurred())
+				Eventually(session).Should(gexec.Exit(1), func() string { return buffer.String() })
+
+				Expect(session.Err.Contents()).To(ContainSubstring("Error: required flag(s) \"buildpack\" not set"))
+			})
+		})
+	})
 }