Just trying to make CodeQL happy

Author: ForestEckhardt

vacation/vacation.go

@@ -93,6 +93,11 @@ func (ta TarArchive) Decompress(destination string) error {
 			return fmt.Errorf("failed to read tar response: %s", err)
 		}
 
+		// Skip if the destination it the destination directory itself i.e. ./
+		if hdr.Name == "."+string(filepath.Separator) {
+			continue
+		}
+
 		err = checkExtractPath(hdr.Name, destination)
 		if err != nil {
 			return err
@@ -328,6 +333,11 @@ func (z ZipArchive) Decompress(destination string) error {
 	}
 
 	for _, f := range zr.File {
+		// Skip if the destination it the destination directory itself i.e. ./
+		if f.Name == "."+string(filepath.Separator) {
+			continue
+		}
+
 		err = checkExtractPath(f.Name, destination)
 		if err != nil {
 			return err
@@ -409,12 +419,8 @@ func (z ZipArchive) Decompress(destination string) error {
 }
 
 // This function checks to see that the given path is within the destination
-// directory or it is the destination directory itself i.e. ./
+// directory
 func checkExtractPath(filePath string, destination string) error {
-	if filePath == "."+string(os.PathSeparator) {
-		return nil
-	}
-
 	destpath := filepath.Join(destination, filePath)
 	if !strings.HasPrefix(destpath, filepath.Clean(destination)+string(os.PathSeparator)) {
 		return fmt.Errorf("illegal file path %q: the file path does not occur within the destination directory", filePath)