Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't award constructs for messages outside of the user's L2 #1675

Closed
linhtphung opened this issue Jan 31, 2025 · 0 comments · Fixed by #1686
Closed

Don't award constructs for messages outside of the user's L2 #1675

linhtphung opened this issue Jan 31, 2025 · 0 comments · Fixed by #1686
Assignees
@ggurdin
Labels
enhancement New feature or request tested on web staging Tested (platform agnostic feature)

Comments

@linhtphung
Copy link

Feature Description

I've been typing in the base language, but I gets tons of pluses flying up for each message. Do we reward learners for messages in the base language? I think we shouldn't.

Rationale

Focus on the target language.

Mockup

No response

Additional Context

No response
@linhtphung linhtphung added the enhancement New feature or request label Jan 31, 2025
@ggurdin ggurdin changed the title Finetuning the animation of + Don't award constructs for messages outside of the user's L2 Feb 3, 2025
@ggurdin ggurdin linked a pull request Feb 3, 2025 that will close this issue
feat: don't award analytics data for messages not in l2 #1686
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggurdin ggurdin

Labels
enhancement New feature or request tested on web staging Tested (platform agnostic feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: don't award analytics data for messages not in l2 pangeachat/client
3 participants
@ggurdin @Kelrap @linhtphung