Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback - Some suggestions #8

Closed
gperdomor opened this issue Jul 4, 2024 · 4 comments
Closed

Feedback - Some suggestions #8

gperdomor opened this issue Jul 4, 2024 · 4 comments

Comments

@gperdomor
Copy link

gperdomor commented Jul 4, 2024

Hi @passivestar...

Thank you for this awesome theme, it's great, but I think can be improved a little bit because in some parts of the UI it's too flat, or in this case, too minimal, I don't known if it's intended 😂

Here are 2 screenshots with the default theme and other 2 with the minimal theme for comparison... Basically in the FileSystem tree, the arrow paths are missing, also some "containers" have no borders and can be a little confusing because everything looks like a label and not a clickable resource (Like the Sprite 2D in the create new node modal, below Recents label)

I hope you can consider this feedback 😄

BTW, the screenshots are for Godot 4.3 beta 2 and minimal theme high ppi v1.5

Screenshot 2024-07-03 at 8 00 44 PM Screenshot 2024-07-03 at 8 00 46 PM Screenshot 2024-07-03 at 8 03 26 PM Screenshot 2024-07-03 at 8 03 31 PM
@gperdomor gperdomor changed the title Some Some suggestions Jul 4, 2024
@gperdomor gperdomor changed the title Some suggestions Feedback - Some suggestions Jul 4, 2024
@passivestar
Copy link
Owner

I don't known if it's intended 😂

It's not, it's just what we have to deal with considering godot's current theming limitations

image

Godot theming still lacks a lot, I'd very much like to have clear visible separation for those containers but since they affect all docks I had to make a choice. Fixing this will require a big amount of work on the engine side, probably something to explore in 4.4

the arrow paths are missing

some people mentioned that, I might bring those back but I'd like to see what it'll look like with just vertical lines, like it's done in vscode. might be a good compromise on minimalism/function

Thanks for the feedback! <3

@gperdomor
Copy link
Author

:o... I understand... thank you for the quick response 👍🏻

@Horops
Copy link

Horops commented Jul 29, 2024

Yeah I came here to say this also. The lack of line (arrow?) paths in the Scene and FileSystem windows makes it really hard to visualize what goes where.
I attached a screenshot for example (though not the best example since the tree is really small in this case so not that hard to follow but in a bigger project it gets unwieldy fast)
I understand it's currently a Godot limitation though as PassiveStar said.
Hope the org can make this change possible sometime soon.
Untitled

@passivestar
Copy link
Owner

There's now a relationship line for the currently selected list item since 57a0d73 in the latest theme version. This is a half measure to make lists clean while providing some guidance. If I were to draw lines for all items some lists would become too noisy, that's especially noticeable on lists that don't need any guides to begin with, such as the sidebars of editor/project settings

Panels for sidebars were added in 67ff2af and the PR to make them possible on the engine side was merged today. Wait for the next dev release of Godot for them to appear (4.4-dev6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants