-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut down on dependencies to get rid of Xcode requirement #1141
Comments
Valid topic. I even also had a short discussion with @sghoweri in gitter.im:
@sghoweri explained the current architecture pretty good:
|
I'd like to better understand the root cause of the issue here (ie. what specifically is causing this unintentional xcode requirement, ex. git?)... wouldn't hurt to also try adding an automated test to help prevent these sorts of issues from popping up in the future. |
It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks! |
@paintedbicycle we did a huge amount of changes to our dependencies and especially finally moved a lot of them from ‚dependencies‘ to ‚devDependencies‘ — are you still experiencing these problems? |
I'm not sure anymore. This is an old issue so I'm happy to close it to keep things clean and since it sounds like a bunch of dependency work has been done that will likely affect this. |
I am using Pattern Lab Node
v5.7.0
onMac
, with Nodev8.15.0
, using aVanilla
Edition.When trying to get a coworker up and running with this, the install failed because they didn't have
Xcode
installed. We tried installing theXcode cli tools
, but that wasn't enough.Expected Behaviour
Some of the dependencies that could be the culprits (just watching the
cli
output during build):fsevents
runsnode-gyp rebuild
a couple times which is my main guess as to the issue herenode-sass
is installedpuppeteer
- installs twice I thinkChromium
gets downloadedActual Behavior
Xcode
requirementSteps to Reproduce
Install via
npm create pattern-lab
The text was updated successfully, but these errors were encountered: