Skip to content

Commit 0891aef

Browse files
authored
[Fix] Typo in statically parsed ref unpacking (dbt-labs#7365)
test statically parsed two-argument ref
1 parent add9242 commit 0891aef

File tree

3 files changed

+38
-1
lines changed

3 files changed

+38
-1
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
kind: Fixes
2+
body: fix typo in unpacking statically parsed ref
3+
time: 2023-04-14T16:36:42.279838-04:00
4+
custom:
5+
Author: MichelleArk
6+
Issue: "7364"

core/dbt/parser/models.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -492,7 +492,7 @@ def populate(self, node: ModelNode, config: ContextConfig, statically_parsed: Di
492492
if len(ref) == 1:
493493
package, name = None, ref[0]
494494
else:
495-
package, name = ref[0], refs[1]
495+
package, name = ref
496496

497497
refs.append(RefArgs(package=package, name=name))
498498

test/unit/test_graph.py

+31
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,37 @@ def test__two_models_simple_ref(self):
215215
],
216216
)
217217

218+
def test__two_models_package_ref(self):
219+
self.use_models(
220+
{
221+
"model_one": "select * from events",
222+
"model_two": "select * from {{ref('test_models_compile', 'model_one')}}",
223+
}
224+
)
225+
226+
config = self.get_config()
227+
manifest = self.load_manifest(config)
228+
compiler = self.get_compiler(config)
229+
linker = compiler.compile(manifest)
230+
231+
self.assertCountEqual(
232+
linker.nodes(),
233+
[
234+
"model.test_models_compile.model_one",
235+
"model.test_models_compile.model_two",
236+
],
237+
)
238+
239+
self.assertCountEqual(
240+
linker.edges(),
241+
[
242+
(
243+
"model.test_models_compile.model_one",
244+
"model.test_models_compile.model_two",
245+
)
246+
],
247+
)
248+
218249
def test__model_materializations(self):
219250
self.use_models(
220251
{

0 commit comments

Comments
 (0)