Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug (Godot 4.3 beta 1): Can't move items in inventory, or from inventory to ItemSlot. #215

Closed
kyle-wannacott opened this issue Jun 2, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@kyle-wannacott
Copy link
Contributor

kyle-wannacott commented Jun 2, 2024

Moving inventory items results in a crash.

Steps to reproduce: Drag and drop inventory item to a new position inside itself, or a ItemSlot/ other inventory.

Error:
image

I think you can check for false instead of null now; from patch notes (https://godotengine.org/article/dev-snapshot-godot-4-3-beta-1/):

Breaking changes:

  • Freed objects are now different than null in comparison operators, and evaluate as falsy (GH-73896).
@peter-kish peter-kish added the bug Something isn't working label Jun 2, 2024
@peter-kish peter-kish added this to the 2.5.0 milestone Jun 2, 2024
@peter-kish
Copy link
Owner

Yeah checking for false would fix the issue in 4.3 beta 1, but I'm afraid it would introduce potential issues in 4.2. So I just went with the is_instance_valid check, which should work in both versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants