Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCP: Vectorize the merge join executor #14216

Closed
qw4990 opened this issue Dec 25, 2019 · 5 comments
Closed

PCP: Vectorize the merge join executor #14216

qw4990 opened this issue Dec 25, 2019 · 5 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@qw4990
Copy link
Contributor

qw4990 commented Dec 25, 2019

Description

Currently, the merge join executor in TiDB is row-based, which compares and joins data from its children row by row.
We can vectorize it to let it do the processing group by group like what we do in the stream aggregation executor.
You can use the vecGroupChecker to find the next group.

Difficulty

  • Medium

Score

  • 3000

Mentor(s)

Recommended Skills

  • Go programming
@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. difficulty/medium labels Dec 25, 2019
@SunRunAway SunRunAway added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 25, 2019
@catror
Copy link
Contributor

catror commented Dec 31, 2019

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 31, 2019

@catror pick up issue success

@SunRunAway
Copy link
Contributor

Hi, @catror
Do you have any ideas or plans to do this PCP, we can make a meeting to discuss it along with @XuHuaiyu and @qw4990 if you have time.

@catror
Copy link
Contributor

catror commented Jan 7, 2020

Hi, @catror
Do you have any ideas or plans to do this PCP, we can make a meeting to discuss it along with @XuHuaiyu and @qw4990 if you have time.

I'm busy these days. But I'm almost done with this issue, please expect a PR this weekend.

@qw4990
Copy link
Contributor Author

qw4990 commented Jan 7, 2020

Hi @catror , thanks for your contribution!
Do you use Slack? I'd like to discuss this issue with you on Slack more detailly before you open a PR 😺.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants