EXPERIMENT: [Python][CI] Optimize for size with MSVC

Author: pitrou

ci/appveyor-cpp-build.bat

@@ -117,6 +117,7 @@ popd
 
 pushd python
 
+set PYARROW_BUILD_VERBOSE=1
 set PYARROW_CMAKE_GENERATOR=%GENERATOR%
 set PYARROW_CXXFLAGS=%ARROW_CXXFLAGS%
 set PYARROW_PARALLEL=2

ci/scripts/python_wheel_windows_build.bat

@@ -104,6 +104,7 @@ popd
 
 echo "=== (%PYTHON_VERSION%) Building wheel ==="
 set PYARROW_BUILD_TYPE=%CMAKE_BUILD_TYPE%
+set PYARROW_BUILD_VERBOSE=1
 set PYARROW_BUNDLE_ARROW_CPP=ON
 set PYARROW_CMAKE_GENERATOR=%CMAKE_GENERATOR%
 set PYARROW_INSTALL_TESTS=ON

python/CMakeLists.txt

@@ -145,6 +145,8 @@ endif()
 
 include(BuildUtils)
 
+string(TOUPPER ${CMAKE_BUILD_TYPE} UPPER_BUILD_TYPE)
+
 # Cython generated code emits way to many warnings at CHECKIN and EVERYTHING
 set(BUILD_WARNING_LEVEL "PRODUCTION")
 
@@ -188,6 +190,10 @@ if(MSVC)
   # "unused function" warning but the code emits another "function
   # call missing argument list" warning.
   string(APPEND CMAKE_CXX_FLAGS " /wd4551")
+
+  string(REPLACE "/O2 /Ob2" "/O1 /Ob1" ${CMAKE_CXX_FLAGS_RELEASE} CMAKE_CXX_FLAGS_RELEASE)
+  string(REPLACE "/O2 /Ob2" "/O1 /Ob1" ${CMAKE_CXX_FLAGS_RELWITHDEBINFO} CMAKE_CXX_FLAGS_RELWITHDEBINFO)
+
 else()
   # Enable perf and other tools to work properly
   string(APPEND CMAKE_CXX_FLAGS " -fno-omit-frame-pointer")

python/setup.py

@@ -291,20 +291,20 @@ def append_cmake_bool(value, varname):
 
             cmake_options.append(
                 f'-DCMAKE_BUILD_TYPE={self.build_type.lower()}')
+            if os.environ.get('PYARROW_BUILD_VERBOSE', '0') == '1':
+                cmake_options.append('-DCMAKE_VERBOSE_MAKEFILE=ON')
 
             extra_cmake_args = shlex.split(self.extra_cmake_args)
 
-            build_tool_args = []
             if sys.platform == 'win32':
                 if not is_64_bit:
                     raise RuntimeError('Not supported on 32-bit Windows')
-            else:
-                build_tool_args.append('--')
-                if os.environ.get('PYARROW_BUILD_VERBOSE', '0') == '1':
-                    cmake_options.append('-DCMAKE_VERBOSE_MAKEFILE=ON')
-                parallel = os.environ.get('PYARROW_PARALLEL')
-                if parallel:
-                    build_tool_args.append(f'-j{parallel}')
+
+            build_tool_args = []
+            build_tool_args.append('--')
+            parallel = os.environ.get('PYARROW_PARALLEL')
+            if parallel:
+                build_tool_args.append(f'-j{parallel}')
 
             # Generate the build files
             print("-- Running cmake for PyArrow")