byte key representation as ImmutableArray<byte>

Author: colibrishin

Libplanet/Crypto/BlsPrivateKey.cs

@@ -30,7 +30,7 @@ namespace Libplanet.Crypto
     public class BlsPrivateKey : IEquatable<BlsPrivateKey>, IPrivateKey
     {
         private const int KeyByteSize = BLS.SECRETKEY_SERIALIZE_SIZE;
-        private readonly IReadOnlyList<byte> _privateKey;
+        private readonly ImmutableArray<byte> _privateKey;
         private BlsPublicKey? _publicKey;
         private BlsSignature? _proofOfPossession;
 
@@ -40,7 +40,8 @@ public class BlsPrivateKey : IEquatable<BlsPrivateKey>, IPrivateKey
         /// </summary>
         public BlsPrivateKey()
         {
-            _privateKey = CryptoConfig.ConsensusCryptoBackend.GeneratePrivateKey();
+            _privateKey = CryptoConfig.ConsensusCryptoBackend.GeneratePrivateKey()
+                .ToImmutableArray();
             _proofOfPossession = CryptoConfig.ConsensusCryptoBackend.GetProofOfPossession(this);
         }
 
@@ -81,7 +82,7 @@ public BlsPrivateKey(IReadOnlyList<byte> privateKey)
                     nameof(privateKey));
             }
 
-            _privateKey = privateKey;
+            _privateKey = privateKey.ToImmutableArray();
             _ = CryptoConfig.ConsensusCryptoBackend.ValidateGetNativePrivateKey(this);
             _proofOfPossession = CryptoConfig.ConsensusCryptoBackend.GetProofOfPossession(this);
         }
@@ -113,7 +114,7 @@ public BlsPublicKey PublicKey
 
         IPublicKey IPrivateKey.PublicKey => PublicKey;
 
-        IReadOnlyList<byte> IPrivateKey.KeyBytes => ByteArray;
+        ImmutableArray<byte> IPrivateKey.KeyBytes => ByteArray;
 
         /// <summary>
         /// Returns the corresponding Proof of Possession. Public key can be aggregated, some public

Libplanet/Crypto/BlsPublicKey.cs

@@ -35,7 +35,7 @@ public class BlsPublicKey : IEquatable<BlsPublicKey>, IPublicKey
     {
         private const int KeyByteSize = BLS.PUBLICKEY_SERIALIZE_SIZE;
 
-        private readonly IReadOnlyList<byte> _publicKey;
+        private readonly ImmutableArray<byte> _publicKey;
 
         /// <summary>
         /// Creates a <see cref="BlsPublicKey"/> instance from the given
@@ -59,12 +59,11 @@ public BlsPublicKey(IReadOnlyList<byte> publicKey)
                 );
             }
 
-            _publicKey = publicKey;
-
+            _publicKey = publicKey.ToImmutableArray();
             _ = CryptoConfig.ConsensusCryptoBackend.ValidateGetNativePublicKey(this);
         }
 
-        public IReadOnlyList<byte> KeyBytes => ToImmutableArray();
+        public ImmutableArray<byte> KeyBytes => ToImmutableArray();
 
         public static bool operator ==(BlsPublicKey left, BlsPublicKey right) =>
             left.Equals(right);

Libplanet/Crypto/BlsSignature.cs

@@ -34,7 +34,7 @@ namespace Libplanet.Crypto
     public sealed class BlsSignature : IEquatable<BlsSignature>
     {
         private const int KeyByteSize = BLS.SIGNATURE_SERIALIZE_SIZE;
-        private readonly IReadOnlyList<byte> _signature;
+        private readonly ImmutableArray<byte> _signature;
 
         /// <summary>
         /// Instantiates a new <see cref="BlsSignature"/> by given <see cref="byte"/>
@@ -65,7 +65,7 @@ public BlsSignature(IReadOnlyList<byte> signature)
                 );
             }
 
-            _signature = signature;
+            _signature = signature.ToImmutableArray();
             _ = CryptoConfig.ConsensusCryptoBackend.ValidateGetNativeSignature(ToByteArray());
         }
 

Libplanet/Crypto/IPrivateKey.cs

@@ -1,4 +1,4 @@
-using System.Collections.Generic;
+using System.Collections.Immutable;
 
 namespace Libplanet.Crypto
 {
@@ -11,7 +11,7 @@ public interface IPrivateKey
         /// <summary>
         /// The <see cref="byte"/> representation of private key.
         /// </summary>
-        IReadOnlyList<byte> KeyBytes { get; }
+        ImmutableArray<byte> KeyBytes { get; }
 
         /// <summary>
         /// The public key pair, <see cref="IPublicKey"/> of private key.

Libplanet/Crypto/IPublicKey.cs

@@ -1,4 +1,5 @@
 using System.Collections.Generic;
+using System.Collections.Immutable;
 
 namespace Libplanet.Crypto
 {
@@ -11,7 +12,7 @@ public interface IPublicKey
         /// <summary>
         /// The <see cref="byte"/> representation of public key.
         /// </summary>
-        IReadOnlyList<byte> KeyBytes { get; }
+        ImmutableArray<byte> KeyBytes { get; }
 
         /// <summary>
         /// Verifies message with base public key method. See base verify method for detailed

Libplanet/Crypto/PrivateKey.cs

@@ -155,7 +155,7 @@ public PublicKey PublicKey
         [Pure]
         public ImmutableArray<byte> ByteArray => ToByteArray().ToImmutableArray();
 
-        public IReadOnlyList<byte> KeyBytes => ByteArray;
+        public ImmutableArray<byte> KeyBytes => ByteArray;
 
         internal ECPrivateKeyParameters KeyParam { get; }
 

Libplanet/Crypto/PublicKey.cs

@@ -52,7 +52,7 @@ internal PublicKey(ECPublicKeyParameters keyParam)
             KeyParam = keyParam;
         }
 
-        public IReadOnlyList<byte> KeyBytes => Format(false);
+        public ImmutableArray<byte> KeyBytes => Format(false).ToImmutableArray();
 
         internal ECPublicKeyParameters KeyParam { get; }