Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Ad blocking #1

Open
amitsuthar69 opened this issue Jan 4, 2025 · 2 comments
Open

Advanced Ad blocking #1

amitsuthar69 opened this issue Jan 4, 2025 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@amitsuthar69
Copy link
Member

Advanced Ad Blocking.

Our current implementation (as of build v1.3.0) blocks the fetching of ad banner scripts but the empty blank placeholder is still visible which kind of looks odd!

We also need to handle some more advanced ad displaying techniques, some of which include:

level 1:

  • Web Banners. (we do handle this but we still have to figure out how're we gonna remove the placeholder as I said earlier.

level 2:

  • Pop Up ads.
  • Pop Under ads [displaying an ad in a new browser window behind the current browser window].
  • Push Notification.

level 3:

  • Native ads [advertising content in a manner that is ‘native’ to its env] [eg: ‘recommended content’ or ‘promoted stories’]
  • Adblock detectors [publishers which force you to turn off your adblocker before accessing the site]
@amitsuthar69 amitsuthar69 added enhancement New feature or request help wanted Extra attention is needed labels Jan 4, 2025
@amitsuthar69
Copy link
Member Author

I guess we can toggle css styles to remove the ad placeholders!

common classes and selectors I found from inspecting various sites:
'adsbygoogle', 'adsbygoogle-noablate', 'data-adsbygoogle-status="done"', 'script[src*='adnxs.com']', etc

PS: I Still can't figure out how to block 'World of Tank' Ads, they suck!!

@amitsuthar69
Copy link
Member Author

I tried modifying HTML in the tunnel but I failed. Need help.
PR: #2
ISSUE: #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant