Skip to content

Commit 477f347

Browse files
authored
Breaking: bump node-abi so that Electron 14+ gets correct ABI (#161)
electron/node-abi#113 was fixed in 3.3.0 and is affecting Electron 14+. With the current node-abi prebuild-install will download ABI 89 for electron 14 and 15 and then modules will fail to load as electron 14 has ABI 97 and electon 15 has ABI 98 in reality. Drops support of Node.js < 10.
1 parent c96c526 commit 477f347

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ jobs:
55
strategy:
66
matrix:
77
os: [ubuntu-latest, macos-latest, windows-latest]
8-
node: [6, 8, 10, 12, 14, 16]
8+
node: [10, 12, 14, 16]
99
arch: [x64]
1010
include:
1111
- os: windows-latest

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"minimist": "^1.2.3",
2727
"mkdirp-classic": "^0.5.3",
2828
"napi-build-utils": "^1.0.1",
29-
"node-abi": "^2.21.0",
29+
"node-abi": "^3.3.0",
3030
"npmlog": "^4.0.1",
3131
"pump": "^3.0.0",
3232
"rc": "^1.2.7",
@@ -64,6 +64,6 @@
6464
},
6565
"homepage": "https://github.com/prebuild/prebuild-install",
6666
"engines": {
67-
"node": ">=6"
67+
"node": ">=10"
6868
}
6969
}

0 commit comments

Comments
 (0)