Skip to content

Commit 1187743

Browse files
bzbarsky-applepull[bot]
authored andcommitted
Align naming in Descriptor cluster XML with the spec. (#24238)
* Align naming in Descriptor cluster XML with the spec. * Regenerate generated files.
1 parent da0e22f commit 1187743

File tree

60 files changed

+118
-91
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+118
-91
lines changed

examples/all-clusters-app/all-clusters-common/all-clusters-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ server cluster BinaryInputBasic = 15 {
396396

397397
server cluster Descriptor = 29 {
398398
struct DeviceTypeStruct {
399-
devtype_id type = 0;
399+
devtype_id deviceType = 0;
400400
int16u revision = 1;
401401
}
402402

examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ server cluster LevelControl = 8 {
346346

347347
server cluster Descriptor = 29 {
348348
struct DeviceTypeStruct {
349-
devtype_id type = 0;
349+
devtype_id deviceType = 0;
350350
int16u revision = 1;
351351
}
352352

examples/bridge-app/bridge-common/bridge-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ server cluster LevelControl = 8 {
193193

194194
server cluster Descriptor = 29 {
195195
struct DeviceTypeStruct {
196-
devtype_id type = 0;
196+
devtype_id deviceType = 0;
197197
int16u revision = 1;
198198
}
199199

examples/chef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ server cluster LevelControl = 8 {
253253

254254
server cluster Descriptor = 29 {
255255
struct DeviceTypeStruct {
256-
devtype_id type = 0;
256+
devtype_id deviceType = 0;
257257
int16u revision = 1;
258258
}
259259

examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ server cluster LevelControl = 8 {
271271

272272
server cluster Descriptor = 29 {
273273
struct DeviceTypeStruct {
274-
devtype_id type = 0;
274+
devtype_id deviceType = 0;
275275
int16u revision = 1;
276276
}
277277

examples/chef/devices/rootnode_contactsensor_lFAGG1bfRO.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ server cluster Groups = 4 {
104104

105105
server cluster Descriptor = 29 {
106106
struct DeviceTypeStruct {
107-
devtype_id type = 0;
107+
devtype_id deviceType = 0;
108108
int16u revision = 1;
109109
}
110110

examples/chef/devices/rootnode_dimmablelight_bCwGYSDpoe.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ server cluster LevelControl = 8 {
253253

254254
server cluster Descriptor = 29 {
255255
struct DeviceTypeStruct {
256-
devtype_id type = 0;
256+
devtype_id deviceType = 0;
257257
int16u revision = 1;
258258
}
259259

examples/chef/devices/rootnode_doorlock_aNKYAreMXE.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ server cluster Groups = 4 {
104104

105105
server cluster Descriptor = 29 {
106106
struct DeviceTypeStruct {
107-
devtype_id type = 0;
107+
devtype_id deviceType = 0;
108108
int16u revision = 1;
109109
}
110110

examples/chef/devices/rootnode_extendedcolorlight_8lcaaYJVAa.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ server cluster LevelControl = 8 {
253253

254254
server cluster Descriptor = 29 {
255255
struct DeviceTypeStruct {
256-
devtype_id type = 0;
256+
devtype_id deviceType = 0;
257257
int16u revision = 1;
258258
}
259259

examples/chef/devices/rootnode_fan_7N2TobIlOX.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ server cluster Groups = 4 {
110110

111111
server cluster Descriptor = 29 {
112112
struct DeviceTypeStruct {
113-
devtype_id type = 0;
113+
devtype_id deviceType = 0;
114114
int16u revision = 1;
115115
}
116116

examples/chef/devices/rootnode_flowsensor_1zVxHedlaV.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ server cluster Groups = 4 {
117117

118118
server cluster Descriptor = 29 {
119119
struct DeviceTypeStruct {
120-
devtype_id type = 0;
120+
devtype_id deviceType = 0;
121121
int16u revision = 1;
122122
}
123123

examples/chef/devices/rootnode_heatingcoolingunit_ncdGai1E5a.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ server cluster LevelControl = 8 {
246246

247247
server cluster Descriptor = 29 {
248248
struct DeviceTypeStruct {
249-
devtype_id type = 0;
249+
devtype_id deviceType = 0;
250250
int16u revision = 1;
251251
}
252252

examples/chef/devices/rootnode_humiditysensor_Xyj4gda6Hb.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ server cluster Groups = 4 {
117117

118118
server cluster Descriptor = 29 {
119119
struct DeviceTypeStruct {
120-
devtype_id type = 0;
120+
devtype_id deviceType = 0;
121121
int16u revision = 1;
122122
}
123123

examples/chef/devices/rootnode_lightsensor_lZQycTFcJK.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ server cluster Groups = 4 {
117117

118118
server cluster Descriptor = 29 {
119119
struct DeviceTypeStruct {
120-
devtype_id type = 0;
120+
devtype_id deviceType = 0;
121121
int16u revision = 1;
122122
}
123123

examples/chef/devices/rootnode_occupancysensor_iHyVgifZuo.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ server cluster Groups = 4 {
117117

118118
server cluster Descriptor = 29 {
119119
struct DeviceTypeStruct {
120-
devtype_id type = 0;
120+
devtype_id deviceType = 0;
121121
int16u revision = 1;
122122
}
123123

examples/chef/devices/rootnode_onofflight_bbs1b7IaOV.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ server cluster LevelControl = 8 {
253253

254254
server cluster Descriptor = 29 {
255255
struct DeviceTypeStruct {
256-
devtype_id type = 0;
256+
devtype_id deviceType = 0;
257257
int16u revision = 1;
258258
}
259259

examples/chef/devices/rootnode_onofflightswitch_FsPlMr090Q.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ server cluster OnOff = 6 {
196196

197197
server cluster Descriptor = 29 {
198198
struct DeviceTypeStruct {
199-
devtype_id type = 0;
199+
devtype_id deviceType = 0;
200200
int16u revision = 1;
201201
}
202202

examples/chef/devices/rootnode_onoffpluginunit_Wtf8ss5EBY.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ server cluster OnOff = 6 {
154154

155155
server cluster Descriptor = 29 {
156156
struct DeviceTypeStruct {
157-
devtype_id type = 0;
157+
devtype_id deviceType = 0;
158158
int16u revision = 1;
159159
}
160160

examples/chef/devices/rootnode_pressuresensor_s0qC9wLH4k.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ server cluster Groups = 4 {
122122

123123
server cluster Descriptor = 29 {
124124
struct DeviceTypeStruct {
125-
devtype_id type = 0;
125+
devtype_id deviceType = 0;
126126
int16u revision = 1;
127127
}
128128

examples/chef/devices/rootnode_speaker_RpzeXdimqA.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ server cluster LevelControl = 8 {
244244

245245
server cluster Descriptor = 29 {
246246
struct DeviceTypeStruct {
247-
devtype_id type = 0;
247+
devtype_id deviceType = 0;
248248
int16u revision = 1;
249249
}
250250

examples/chef/devices/rootnode_temperaturesensor_Qy1zkNW7c3.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ server cluster Groups = 4 {
117117

118118
server cluster Descriptor = 29 {
119119
struct DeviceTypeStruct {
120-
devtype_id type = 0;
120+
devtype_id deviceType = 0;
121121
int16u revision = 1;
122122
}
123123

examples/chef/devices/rootnode_thermostat_bm3fb8dhYi.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ server cluster Groups = 4 {
104104

105105
server cluster Descriptor = 29 {
106106
struct DeviceTypeStruct {
107-
devtype_id type = 0;
107+
devtype_id deviceType = 0;
108108
int16u revision = 1;
109109
}
110110

examples/chef/devices/rootnode_windowcovering_RLCxaGi9Yx.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ server cluster Groups = 4 {
104104

105105
server cluster Descriptor = 29 {
106106
struct DeviceTypeStruct {
107-
devtype_id type = 0;
107+
devtype_id deviceType = 0;
108108
int16u revision = 1;
109109
}
110110

examples/contact-sensor-app/contact-sensor-common/contact-sensor-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ server cluster Groups = 4 {
112112

113113
server cluster Descriptor = 29 {
114114
struct DeviceTypeStruct {
115-
devtype_id type = 0;
115+
devtype_id deviceType = 0;
116116
int16u revision = 1;
117117
}
118118

examples/dynamic-bridge-app/bridge-common/bridge-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ server cluster LevelControl = 8 {
193193

194194
server cluster Descriptor = 29 {
195195
struct DeviceTypeStruct {
196-
devtype_id type = 0;
196+
devtype_id deviceType = 0;
197197
int16u revision = 1;
198198
}
199199

examples/light-switch-app/light-switch-common/light-switch-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ client cluster OnOff = 6 {
300300

301301
server cluster Descriptor = 29 {
302302
struct DeviceTypeStruct {
303-
devtype_id type = 0;
303+
devtype_id deviceType = 0;
304304
int16u revision = 1;
305305
}
306306

examples/lighting-app/lighting-common/lighting-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ server cluster LevelControl = 8 {
273273

274274
server cluster Descriptor = 29 {
275275
struct DeviceTypeStruct {
276-
devtype_id type = 0;
276+
devtype_id deviceType = 0;
277277
int16u revision = 1;
278278
}
279279

examples/lighting-app/nxp/zap/lighting-on-off.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ server cluster LevelControl = 8 {
273273

274274
server cluster Descriptor = 29 {
275275
struct DeviceTypeStruct {
276-
devtype_id type = 0;
276+
devtype_id deviceType = 0;
277277
int16u revision = 1;
278278
}
279279

examples/lock-app/lock-common/lock-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ server cluster OnOff = 6 {
9090

9191
server cluster Descriptor = 29 {
9292
struct DeviceTypeStruct {
93-
devtype_id type = 0;
93+
devtype_id deviceType = 0;
9494
int16u revision = 1;
9595
}
9696

examples/ota-provider-app/ota-provider-common/ota-provider-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ struct LabelStruct {
88

99
server cluster Descriptor = 29 {
1010
struct DeviceTypeStruct {
11-
devtype_id type = 0;
11+
devtype_id deviceType = 0;
1212
int16u revision = 1;
1313
}
1414

examples/ota-requestor-app/ota-requestor-common/ota-requestor-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ server cluster OnOff = 6 {
170170

171171
server cluster Descriptor = 29 {
172172
struct DeviceTypeStruct {
173-
devtype_id type = 0;
173+
devtype_id deviceType = 0;
174174
int16u revision = 1;
175175
}
176176

examples/placeholder/linux/apps/app1/config.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@ server cluster LevelControl = 8 {
418418

419419
server cluster Descriptor = 29 {
420420
struct DeviceTypeStruct {
421-
devtype_id type = 0;
421+
devtype_id deviceType = 0;
422422
int16u revision = 1;
423423
}
424424

examples/placeholder/linux/apps/app2/config.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@ server cluster LevelControl = 8 {
418418

419419
server cluster Descriptor = 29 {
420420
struct DeviceTypeStruct {
421-
devtype_id type = 0;
421+
devtype_id deviceType = 0;
422422
int16u revision = 1;
423423
}
424424

examples/pump-app/pump-common/pump-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ server cluster LevelControl = 8 {
184184

185185
server cluster Descriptor = 29 {
186186
struct DeviceTypeStruct {
187-
devtype_id type = 0;
187+
devtype_id deviceType = 0;
188188
int16u revision = 1;
189189
}
190190

examples/pump-controller-app/pump-controller-common/pump-controller-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ client cluster OnOff = 6 {
8383

8484
server cluster Descriptor = 29 {
8585
struct DeviceTypeStruct {
86-
devtype_id type = 0;
86+
devtype_id deviceType = 0;
8787
int16u revision = 1;
8888
}
8989

examples/temperature-measurement-app/esp32/main/temperature-measurement.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ struct LabelStruct {
88

99
server cluster Descriptor = 29 {
1010
struct DeviceTypeStruct {
11-
devtype_id type = 0;
11+
devtype_id deviceType = 0;
1212
int16u revision = 1;
1313
}
1414

examples/thermostat/thermostat-common/thermostat.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ server cluster Scenes = 5 {
246246

247247
server cluster Descriptor = 29 {
248248
struct DeviceTypeStruct {
249-
devtype_id type = 0;
249+
devtype_id deviceType = 0;
250250
int16u revision = 1;
251251
}
252252

examples/tv-app/tv-common/tv-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ server cluster LevelControl = 8 {
154154

155155
server cluster Descriptor = 29 {
156156
struct DeviceTypeStruct {
157-
devtype_id type = 0;
157+
devtype_id deviceType = 0;
158158
int16u revision = 1;
159159
}
160160

examples/tv-casting-app/tv-casting-common/tv-casting-app.matter

+2-2
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,7 @@ server cluster BinaryInputBasic = 15 {
519519

520520
client cluster Descriptor = 29 {
521521
struct DeviceTypeStruct {
522-
devtype_id type = 0;
522+
devtype_id deviceType = 0;
523523
int16u revision = 1;
524524
}
525525

@@ -533,7 +533,7 @@ client cluster Descriptor = 29 {
533533

534534
server cluster Descriptor = 29 {
535535
struct DeviceTypeStruct {
536-
devtype_id type = 0;
536+
devtype_id deviceType = 0;
537537
int16u revision = 1;
538538
}
539539

examples/window-app/common/window-app.matter

+1-1
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ server cluster Scenes = 5 {
226226

227227
server cluster Descriptor = 29 {
228228
struct DeviceTypeStruct {
229-
devtype_id type = 0;
229+
devtype_id deviceType = 0;
230230
int16u revision = 1;
231231
}
232232

src/app/clusters/descriptor/descriptor.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@ CHIP_ERROR DescriptorAttrAccess::ReadDeviceAttribute(EndpointId endpoint, Attrib
120120

121121
for (auto & deviceType : deviceTypeList)
122122
{
123-
deviceStruct.type = deviceType.deviceId;
124-
deviceStruct.revision = deviceType.deviceVersion;
123+
deviceStruct.deviceType = deviceType.deviceId;
124+
deviceStruct.revision = deviceType.deviceVersion;
125125
ReturnErrorOnFailure(encoder.Encode(deviceStruct));
126126
}
127127

src/app/tests/suites/TestDescriptorCluster.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ tests:
3232
command: "readAttribute"
3333
attribute: "DeviceTypeList"
3434
response:
35-
value: [{ type: 22, revision: 1 }]
35+
value: [{ DeviceType: 22, Revision: 1 }]
3636

3737
- label: "Read attribute Server list"
3838
command: "readAttribute"

src/app/zap-templates/zcl/data-model/chip/descriptor-cluster.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ limitations under the License.
1919

2020
<struct name="DeviceTypeStruct">
2121
<cluster code="0x001d"/>
22-
<item name="type" type="DEVTYPE_ID"/>
23-
<item name="revision" type="INT16U"/>
22+
<item name="DeviceType" type="DEVTYPE_ID"/>
23+
<item name="Revision" type="INT16U"/>
2424
</struct>
2525

2626
<cluster>

0 commit comments

Comments
 (0)