Skip to content

Commit 1476972

Browse files
tcave-bbrestyled-commits
authored andcommitted
Bug/air quality sensor app leak (#28619)
* free handle on error * corrected README.md * Restyled by prettier-markdown * updated readme * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <commits@restyled.io>
1 parent 9084cd7 commit 1476972

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

examples/air-quality-sensor-app/linux/AirQualitySensorAppAttrUpdateDelegate.cpp

+4-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,10 @@ void AirQualitySensorAttrUpdateHandler::HandleCommand(intptr_t context)
106106
auto * self = reinterpret_cast<AirQualitySensorAttrUpdateHandler *>(context);
107107
std::string clusterName = self->mJsonValue["Name"].asString();
108108

109-
VerifyOrReturn(!self->mJsonValue.empty(), ChipLogError(NotSpecified, "Invalid JSON event command received"));
109+
VerifyOrReturn(!self->mJsonValue.empty(), {
110+
ChipLogError(NotSpecified, "Invalid JSON event command received");
111+
Platform::Delete(self);
112+
});
110113

111114
if (clusterName == "AirQuality")
112115
{

examples/air-quality-sensor-app/linux/README.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -116,30 +116,30 @@ To cross-compile this example on x64 host and run on **NXP i.MX 8M Mini**
116116
## Trigger event using air-quality-sensor-app event named pipe
117117

118118
You can send a command to air-quality-sensor-app to trigger specific event via
119-
air-quality-sensor-app event named pipe /tmp/chip_air_quality_fifo-<PID>.
119+
air-quality-sensor-app event named pipe /tmp/chip_air_quality_fifo\*<PID>.
120120

121121
### Trigger air quality change event
122122

123123
Generate event `AirQuality`, to change the air quality value.
124124

125125
```
126-
$ echo '{"Name":"AirQuality","NewValue":3}' > /tmp/chip_air_quality_fifo-<PID>
126+
$ echo '{"Name":"AirQuality","NewValue":3}' > /tmp/chip_air_quality_fifo_<PID>
127127
```
128128

129129
### Trigger Temperature change event
130130

131131
Generate event `TemperatureMeasurement`, to change the temperate value.
132132

133133
```
134-
$ echo '{"Name":"TemperatureMeasurement","NewValue":18}' > /tmp/chip_air_quality_fifo-<PID>
134+
$ echo '{"Name":"TemperatureMeasurement","NewValue":18}' > /tmp/chip_air_quality_fifo_<PID>
135135
```
136136

137137
### Trigger Humidity change event
138138

139139
Generate event `RelativeHumidityMeasurement`, to change the temperate value.
140140

141141
```
142-
$ echo '{"Name":"RelativeHumidityMeasurement","NewValue":60}' > /tmp/chip_air_quality_fifo-<PID>
142+
$ echo '{"Name":"RelativeHumidityMeasurement","NewValue":60}' > /tmp/chip_air_quality_fifo_<PID>
143143
```
144144

145145
### Trigger concentration change event
@@ -150,5 +150,5 @@ clusters.
150150
Generate event `CarbonDioxideConcentrationMeasurement`, to change the CO2 value.
151151

152152
```
153-
$ echo '{"Name":"CarbonDioxideConcentrationMeasurement","NewValue":400}' > /tmp/chip_air_quality_fifo-<PID>
153+
$ echo '{"Name":"CarbonDioxideConcentrationMeasurement","NewValue":400}' > /tmp/chip_air_quality_fifo_<PID>
154154
```

0 commit comments

Comments
 (0)