Skip to content

Commit 1536580

Browse files
arkqpull[bot]
authored andcommitted
Do not use getenv() in Tizen GN config (#26411)
Using getenv is discouraged, because it will get the value from the environment of the build system only on first use. Any environment changes after that will not be reflected in the build.
1 parent 39a2e02 commit 1536580

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

build/config/tizen/config.gni

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414

1515
declare_args() {
1616
# Location of Tizen SDK
17-
tizen_sdk_root = getenv("TIZEN_SDK_ROOT")
17+
tizen_sdk_root = ""
1818

1919
# Location of Tizen SDK sysroot
20-
tizen_sdk_sysroot = getenv("TIZEN_SDK_SYSROOT")
20+
tizen_sdk_sysroot = ""
2121
}

src/test_driver/tizen/README.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,10 @@ argument of the `gn gen` command.
4747
# Generate test target
4848
gn gen --check --fail-on-unused-args \
4949
--root="$PWD/src/test_driver/tizen" \
50-
--args="target_os=\"tizen\" target_cpu=\"arm\" chip_config_network_layer_ble=false" \
50+
--args="target_os=\"tizen\" target_cpu=\"arm\" \
51+
tizen_sdk_root=\"$TIZEN_SDK_ROOT\" \
52+
tizen_sdk_sysroot=\"$TIZEN_SDK_SYSROOT\"
53+
chip_config_network_layer_ble=false" \
5154
out/tizen-check
5255
# Run Tizen QEMU-based tests
5356
ninja -C out/tizen-check check

0 commit comments

Comments
 (0)