Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 1686964

Browse files
bzbarsky-applepull[bot]
authored andcommittedAug 12, 2023
Exclude some redundant things from Darwin build CI. (#16551)
1 parent 6727c78 commit 1686964

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed
 

‎.github/workflows/build.yaml

+13-6
Original file line numberDiff line numberDiff line change
@@ -321,14 +321,21 @@ jobs:
321321
scripts/run_in_build_env.sh "ninja -C ./out/$BUILD_TYPE"
322322
- name: Setup Build, Run Build and Run Tests
323323
timeout-minutes: 120
324-
# Just go ahead and do the "all" build; on Darwin that's fairly
325-
# fast. If this ever becomes slow, we can think about ways to do
326-
# the examples-linux-standalone.yaml tests on darwin without too
327-
# much code duplication.
328324
run: |
329-
for BUILD_TYPE in clang python_lib; do
325+
for BUILD_TYPE in default python_lib; do
330326
case $BUILD_TYPE in
331-
"clang") GN_ARGS='is_clang=true target_os="all" is_asan=true pw_command_launcher="`pwd`/../scripts/helpers/clang-tidy-launcher.py"';;
327+
# We want to build various standalone example apps
328+
# (similar to what examples-linux-standalone.yaml
329+
# does), so use target_os="all" to get those picked
330+
# up as part of the "unified" build. But then to
331+
# save CI resources we want to exclude a few
332+
# redundant things:
333+
#
334+
# * the mbedtls build, since we don't really plan to
335+
# use that on Darwin.
336+
# * the "host clang" build, which uses the pigweed
337+
# clang.
338+
"default") GN_ARGS='target_os="all" is_asan=true enable_host_clang_build=false enable_host_gcc_mbedtls_build=false pw_command_launcher="`pwd`/../scripts/helpers/clang-tidy-launcher.py"';;
332339
"python_lib") GN_ARGS='enable_rtti=true enable_pylib=true';;
333340
esac
334341
scripts/build/gn_gen.sh --args="$GN_ARGS"

0 commit comments

Comments
 (0)
Please sign in to comment.