Added a copy constructor for SensitiveDataBuffer (#32426)

thivya-amazon · pull[bot] · commit 338116556441 · 2024-05-10T21:15:48.000Z
* Added a copy constructor for SensitiveDataBuffer

* Removed commented code.
diff --git a/src/app/icd/client/RefreshKeySender.cpp b/src/app/icd/client/RefreshKeySender.cpp
@@ -32,12 +32,9 @@ RefreshKeySender::RefreshKeySender(CheckInDelegate * checkInDelegate, const ICDC
                                    ICDClientStorage * icdClientStorage, InteractionModelEngine * engine,
                                    const RefreshKeyBuffer & refreshKeyBuffer) :
     mpCheckInDelegate(checkInDelegate),
-    mICDClientInfo(icdClientInfo), mpICDClientStorage(icdClientStorage), mpImEngine(engine),
+    mICDClientInfo(icdClientInfo), mpICDClientStorage(icdClientStorage), mpImEngine(engine), mNewKey(refreshKeyBuffer),
     mOnConnectedCallback(HandleDeviceConnected, this), mOnConnectionFailureCallback(HandleDeviceConnectionFailure, this)
-
-{
-    mNewKey = refreshKeyBuffer;
-}
+{}
 
 CHIP_ERROR RefreshKeySender::RegisterClientWithNewKey(Messaging::ExchangeManager & exchangeMgr, const SessionHandle & sessionHandle)
 {
diff --git a/src/crypto/CHIPCryptoPAL.h b/src/crypto/CHIPCryptoPAL.h
@@ -266,7 +266,8 @@ class SensitiveDataBuffer
         // Sanitize after use
         ClearSecretData(mBytes);
     }
-
+    SensitiveDataBuffer() {}
+    SensitiveDataBuffer(const SensitiveDataBuffer & other) { *this = other; }
     SensitiveDataBuffer & operator=(const SensitiveDataBuffer & other)
     {
         // Guard self assignment

Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,8 @@ class SensitiveDataBuffer`
`266`	`266`	`// Sanitize after use`
`267`	`267`	`ClearSecretData(mBytes);`
`268`	`268`	`}`
`269`		`-`
	`269`	`+ SensitiveDataBuffer() {}`
	`270`	`+ SensitiveDataBuffer(const SensitiveDataBuffer & other) { *this = other; }`
`270`	`271`	`SensitiveDataBuffer & operator=(const SensitiveDataBuffer & other)`
`271`	`272`	`{`
`272`	`273`	`// Guard self assignment`