[Ameba] Implement reading and decoding factorydata from flash (#23758)

* [FactoryData] Implement reading and decoding factorydata from flash
- Add FactoryDataDecoder
- Revise FactoryDataProvider
- Change chipinterface initialization order
- Add CHIP_ENABLE_AMEBA_FACTORY_DATA macro to enable/disable flash factorydata
- Revise filepath in mbedtls.cmake

* [Build] Fix warning and errors

* [Build] ignore warning for unused label

* [factorydata] dont read factorydata if CONFIG_ENABLE_AMEBA_FACTORY_DATA is disabled

Co-authored-by: Andrei Litvin <andy314@gmail.com>

Author: 2 people

config/ameba/chip.cmake

@@ -26,6 +26,7 @@ list(
     -DCONFIG_PLATFORM_8721D
     -DCONFIG_USE_MBEDTLS_ROM_ALG
     -DCONFIG_FUNCION_O0_OPTIMIZE
+    -DCONFIG_ENABLE_AMEBA_FACTORY_DATA=0
     -DDM_ODM_SUPPORT_TYPE=32
     -DCHIP_DEVICE_LAYER_TARGET=Ameba
     -DMBEDTLS_CONFIG_FILE=<mbedtls_config.h>
@@ -43,6 +44,7 @@ list(
     -Wno-unused-variable
     -Wno-deprecated-declarations
     -Wno-unused-parameter
+    -Wno-unused-label
     -Wno-format
     -Wno-stringop-truncation
     -Wno-format-nonliteral

examples/all-clusters-app/ameba/chip_main.cmake

@@ -257,6 +257,7 @@ list(
     -DCHIP_HAVE_CONFIG_H
     -DMBEDTLS_CONFIG_FILE=<mbedtls_config.h>
     -DCHIP_SHELL_MAX_TOKENS=11
+    -DCONFIG_ENABLE_AMEBA_FACTORY_DATA=0
 )
 
 if (matter_enable_persistentstorage_audit)

examples/all-clusters-app/ameba/main/chipinterface.cpp

@@ -131,6 +131,7 @@ static void InitServer(intptr_t context)
     initParams.InitializeStaticResourcesBeforeServerInit();
     chip::Server::GetInstance().Init(initParams);
     gExampleDeviceInfoProvider.SetStorageDelegate(&Server::GetInstance().GetPersistentStorage());
+    // TODO: Use our own DeviceInfoProvider
     chip::DeviceLayer::SetDeviceInfoProvider(&gExampleDeviceInfoProvider);
 
     NetWorkCommissioningInstInit();
@@ -157,22 +158,23 @@ extern "C" void ChipTest(void)
 
     initPref();
 
-    // Initialize device attestation, commissionable data and device instance info
-    // TODO: Use our own DeviceInstanceInfoProvider
-    // SetDeviceInstanceInfoProvider(&mFactoryDataProvider);
+    mFactoryDataProvider.Init();
     SetCommissionableDataProvider(&mFactoryDataProvider);
     SetDeviceAttestationCredentialsProvider(&mFactoryDataProvider);
+
     CHIPDeviceManager & deviceMgr = CHIPDeviceManager::GetInstance();
 
     err = deviceMgr.Init(&EchoCallbacks);
     if (err != CHIP_NO_ERROR)
     {
         ChipLogError(DeviceLayer, "DeviceManagerInit() - ERROR!\r\n");
     }
-    else
-    {
-        ChipLogProgress(DeviceLayer, "DeviceManagerInit() - OK\r\n");
-    }
+
+    // Set DeviceInstanceInfoProvider after CHIPDeviceManager init
+    // CHIPDeviceManager init will set GenericDeviceInsanceInfoProvider first
+#if CONFIG_ENABLE_AMEBA_FACTORY_DATA
+    SetDeviceInstanceInfoProvider(&mFactoryDataProvider);
+#endif
 
     chip::DeviceLayer::PlatformMgr().ScheduleWork(InitServer, 0);
 

src/platform/Ameba/BUILD.gn

@@ -35,6 +35,8 @@ static_library("Ameba") {
     "ConnectivityManagerImpl.h",
     "DiagnosticDataProviderImpl.cpp",
     "DiagnosticDataProviderImpl.h",
+    "FactoryDataDecoder.cpp",
+    "FactoryDataDecoder.h",
     "FactoryDataProvider.cpp",
     "FactoryDataProvider.h",
     "KeyValueStoreManagerImpl.cpp",

src/platform/Ameba/FactoryDataDecoder.cpp

@@ -0,0 +1,46 @@
+/*
+ *
+ *    Copyright (c) 2022 Project CHIP Authors
+ *
+ *    Licensed under the Apache License, Version 2.0 (the "License");
+ *    you may not use this file except in compliance with the License.
+ *    You may obtain a copy of the License at
+ *
+ *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
+ */
+
+#include "FactoryDataDecoder.h"
+#include "chip_porting.h"
+#include <platform/internal/CHIPDeviceLayerInternal.h>
+
+namespace chip {
+namespace DeviceLayer {
+
+CHIP_ERROR FactoryDataDecoder::ReadFactoryData(uint8_t * buffer, uint16_t * pfactorydata_len)
+{
+    uint32_t ret = 0;
+    ret          = ReadFactory(buffer, pfactorydata_len);
+    if (ret != 1)
+        return CHIP_ERROR_INTERNAL;
+
+    return CHIP_NO_ERROR;
+}
+
+CHIP_ERROR FactoryDataDecoder::DecodeFactoryData(uint8_t * buffer, FactoryData * fdata, uint16_t factorydata_len)
+{
+    uint32_t ret = 0;
+    ret          = DecodeFactory(buffer, fdata, factorydata_len);
+    if (ret != 0)
+        return CHIP_ERROR_INTERNAL;
+
+    return CHIP_NO_ERROR;
+}
+
+} // namespace DeviceLayer
+} // namespace chip

src/platform/Ameba/FactoryDataDecoder.h

@@ -0,0 +1,38 @@
+/*
+ *
+ *    Copyright (c) 2022 Project CHIP Authors
+ *
+ *    Licensed under the Apache License, Version 2.0 (the "License");
+ *    you may not use this file except in compliance with the License.
+ *    You may obtain a copy of the License at
+ *
+ *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
+ */
+
+#pragma once
+
+#include <platform/internal/CHIPDeviceLayerInternal.h>
+
+namespace chip {
+namespace DeviceLayer {
+
+class FactoryDataDecoder
+{
+public:
+    CHIP_ERROR ReadFactoryData(uint8_t * buffer, uint16_t * pfactorydata_len);
+    CHIP_ERROR DecodeFactoryData(uint8_t * buffer, FactoryData * fdata, uint16_t factorydata_len);
+    static FactoryDataDecoder & GetInstance()
+    {
+        static FactoryDataDecoder instance;
+        return instance;
+    }
+};
+
+} // namespace DeviceLayer
+} // namespace chip