Skip to content

Commit 3784161

Browse files
bzbarsky-applepull[bot]
authored andcommitted
Add support for running YAML tests against bridge-app. (#23198)
And run Test_TC_BRBINFO_* against it. Fixes #23147
1 parent 4194d4d commit 3784161

File tree

6 files changed

+23
-3
lines changed

6 files changed

+23
-3
lines changed

.github/workflows/darwin-tests.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ jobs:
9494
--target darwin-x64-ota-provider-${BUILD_VARIANT} \
9595
--target darwin-x64-ota-requestor-${BUILD_VARIANT} \
9696
--target darwin-x64-tv-app-${BUILD_VARIANT} \
97+
--target darwin-x64-bridge-app-${BUILD_VARIANT} \
9798
build \
9899
--copy-artifacts-to objdir-clone \
99100
"
@@ -112,6 +113,7 @@ jobs:
112113
--ota-provider-app ./out/darwin-x64-ota-provider-${BUILD_VARIANT}/chip-ota-provider-app \
113114
--ota-requestor-app ./out/darwin-x64-ota-requestor-${BUILD_VARIANT}/chip-ota-requestor-app \
114115
--tv-app ./out/darwin-x64-tv-app-${BUILD_VARIANT}/chip-tv-app \
116+
--bridge-app ./out/darwin-x64-tv-app-${BUILD_VARIANT}/chip-bridge-app \
115117
"
116118
- name: Uploading core files
117119
uses: actions/upload-artifact@v2

.github/workflows/tests.yaml

+4
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,7 @@ jobs:
189189
--target linux-x64-ota-provider-${BUILD_VARIANT} \
190190
--target linux-x64-ota-requestor-${BUILD_VARIANT} \
191191
--target linux-x64-tv-app-${BUILD_VARIANT} \
192+
--target linux-x64-bridge-app-${BUILD_VARIANT} \
192193
build \
193194
--copy-artifacts-to objdir-clone \
194195
"
@@ -206,6 +207,7 @@ jobs:
206207
--ota-provider-app ./out/linux-x64-ota-provider-${BUILD_VARIANT}/chip-ota-provider-app \
207208
--ota-requestor-app ./out/linux-x64-ota-requestor-${BUILD_VARIANT}/chip-ota-requestor-app \
208209
--tv-app ./out/linux-x64-tv-app-${BUILD_VARIANT}/chip-tv-app \
210+
--bridge-app ./out/linux-x64-tv-app-${BUILD_VARIANT}/chip-bridge-app \
209211
"
210212
- name: Uploading core files
211213
uses: actions/upload-artifact@v2
@@ -291,6 +293,7 @@ jobs:
291293
--target darwin-x64-ota-provider-${BUILD_VARIANT} \
292294
--target darwin-x64-ota-requestor-${BUILD_VARIANT} \
293295
--target darwin-x64-tv-app-${BUILD_VARIANT} \
296+
--target darwin-x64-bridge-app-${BUILD_VARIANT} \
294297
build \
295298
--copy-artifacts-to objdir-clone \
296299
"
@@ -309,6 +312,7 @@ jobs:
309312
--ota-provider-app ./out/darwin-x64-ota-provider-${BUILD_VARIANT}/chip-ota-provider-app \
310313
--ota-requestor-app ./out/darwin-x64-ota-requestor-${BUILD_VARIANT}/chip-ota-requestor-app \
311314
--tv-app ./out/darwin-x64-tv-app-${BUILD_VARIANT}/chip-tv-app \
315+
--bridge-app ./out/darwin-x64-tv-app-${BUILD_VARIANT}/chip-bridge-app \
312316
"
313317
- name: Uploading core files
314318
uses: actions/upload-artifact@v2

scripts/tests/chiptest/__init__.py

+2
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ def target_for_name(name: str):
2727
return TestTarget.LOCK
2828
if name.startswith("OTA_"):
2929
return TestTarget.OTA
30+
if name.startswith("Test_TC_BRBINFO_"):
31+
return TestTarget.BRIDGE
3032
return TestTarget.ALL_CLUSTERS
3133

3234

scripts/tests/chiptest/linux.py

+1
Original file line numberDiff line numberDiff line change
@@ -148,4 +148,5 @@ def PathsWithNetworkNamespaces(paths: ApplicationPaths) -> ApplicationPaths:
148148
ota_provider_app='ip netns exec app'.split() + paths.ota_provider_app,
149149
ota_requestor_app='ip netns exec app'.split() + paths.ota_requestor_app,
150150
tv_app='ip netns exec app'.split() + paths.tv_app,
151+
bridge_app='ip netns exec app'.split() + paths.bridge_app,
151152
)

scripts/tests/chiptest/test_definition.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ class TestTarget(Enum):
153153
TV = auto()
154154
LOCK = auto()
155155
OTA = auto()
156+
BRIDGE = auto()
156157

157158

158159
@dataclass
@@ -163,9 +164,10 @@ class ApplicationPaths:
163164
ota_provider_app: typing.List[str]
164165
ota_requestor_app: typing.List[str]
165166
tv_app: typing.List[str]
167+
bridge_app: typing.List[str]
166168

167169
def items(self):
168-
return [self.chip_tool, self.all_clusters_app, self.lock_app, self.ota_provider_app, self.ota_requestor_app, self.tv_app]
170+
return [self.chip_tool, self.all_clusters_app, self.lock_app, self.ota_provider_app, self.ota_requestor_app, self.tv_app, self.bridge_app]
169171

170172

171173
@dataclass
@@ -229,6 +231,8 @@ def Run(self, runner, apps_register, paths: ApplicationPaths, pics_file: str, ti
229231
target_app = paths.lock_app
230232
elif self.target == TestTarget.OTA:
231233
target_app = paths.ota_requestor_app
234+
elif self.target == TestTarget.BRIDGE:
235+
target_app = paths.bridge_app
232236
else:
233237
raise Exception("Unknown test target - "
234238
"don't know which application to run")

scripts/tests/run_test_suite.py

+9-2
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,9 @@ def cmd_list(context):
189189
@click.option(
190190
'--tv-app',
191191
help='what tv app to use')
192+
@click.option(
193+
'--bridge-app',
194+
help='what bridge app to use')
192195
@click.option(
193196
'--pics-file',
194197
type=click.Path(exists=True),
@@ -200,7 +203,7 @@ def cmd_list(context):
200203
type=int,
201204
help='If provided, fail if a test runs for longer than this time')
202205
@click.pass_context
203-
def cmd_run(context, iterations, all_clusters_app, lock_app, ota_provider_app, ota_requestor_app, tv_app, pics_file, test_timeout_seconds):
206+
def cmd_run(context, iterations, all_clusters_app, lock_app, ota_provider_app, ota_requestor_app, tv_app, bridge_app, pics_file, test_timeout_seconds):
204207
runner = chiptest.runner.Runner()
205208

206209
if all_clusters_app is None:
@@ -218,14 +221,18 @@ def cmd_run(context, iterations, all_clusters_app, lock_app, ota_provider_app, o
218221
if tv_app is None:
219222
tv_app = FindBinaryPath('chip-tv-app')
220223

224+
if bridge_app is None:
225+
bridge_app = FindBinaryPath('chip-bridge-app')
226+
221227
# Command execution requires an array
222228
paths = chiptest.ApplicationPaths(
223229
chip_tool=[context.obj.chip_tool],
224230
all_clusters_app=[all_clusters_app],
225231
lock_app=[lock_app],
226232
ota_provider_app=[ota_provider_app],
227233
ota_requestor_app=[ota_requestor_app],
228-
tv_app=[tv_app]
234+
tv_app=[tv_app],
235+
bridge_app=[bridge_app]
229236
)
230237

231238
if sys.platform == 'linux':

0 commit comments

Comments
 (0)