Skip to content

Commit 4013491

Browse files
bzbarsky-applepull[bot]
authored andcommitted
Add Constants.h to the secure_channel sources. (#28219)
This causes gn to correctly notice the circular dependencies between secure_channel and messaging and secure_channel and transport, which are inherent in the spec. Annotate those circular dependencies.
1 parent 5ce5d0d commit 4013491

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

src/protocols/secure_channel/BUILD.gn

+14
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ static_library("secure_channel") {
1010
"CASEServer.h",
1111
"CASESession.cpp",
1212
"CASESession.h",
13+
"Constants.h",
1314
"DefaultSessionResumptionStorage.cpp",
1415
"DefaultSessionResumptionStorage.h",
1516
"PASESession.cpp",
@@ -38,5 +39,18 @@ static_library("secure_channel") {
3839
"${chip_root}/src/system",
3940
"${chip_root}/src/tracing",
4041
"${chip_root}/src/tracing:macros",
42+
"${chip_root}/src/transport",
43+
]
44+
45+
# secure channel requires messaging so it can send messages (e.g. for
46+
# CASE/PASE handshakes). messaging requires secure channel so that it can do
47+
# things like send standalone acks, which are a secure channel concept.
48+
#
49+
# secure channel requires transport so it can deal with sessions. transport
50+
# requires secure channel so it can detect control messages, which are a
51+
# secure channel concept.
52+
allow_circular_includes_from = [
53+
"${chip_root}/src/messaging",
54+
"${chip_root}/src/transport",
4155
]
4256
}

0 commit comments

Comments
 (0)