Code review comments

Damian-Nordic · Damian-Nordic · commit 41778cc59bff · 2022-10-17T16:49:13.000+02:00
diff --git a/src/crypto/CHIPCryptoPALPSA.cpp b/src/crypto/CHIPCryptoPALPSA.cpp
@@ -782,8 +782,7 @@ P256Keypair::~P256Keypair()
 
 CHIP_ERROR P256Keypair::NewCertificateSigningRequest(uint8_t * out_csr, size_t & csr_length) const
 {
-    VerifyOrReturnError(out_csr != nullptr, CHIP_ERROR_INVALID_ARGUMENT);
-    VerifyOrReturnError(csr_length > 0, CHIP_ERROR_INVALID_ARGUMENT);
+    VerifyOrReturnError(isBufferNonEmpty(out_csr, csr_length), CHIP_ERROR_INVALID_ARGUMENT);
     VerifyOrReturnError(mInitialized, CHIP_ERROR_WELL_UNINITIALIZED);
 
     MutableByteSpan csr(out_csr, csr_length);

Original file line number	Diff line number	Diff line change
`@@ -782,8 +782,7 @@ P256Keypair::~P256Keypair()`
`782`	`782`
`783`	`783`	`CHIP_ERROR P256Keypair::NewCertificateSigningRequest(uint8_t * out_csr, size_t & csr_length) const`
`784`	`784`	`{`
`785`		`- VerifyOrReturnError(out_csr != nullptr, CHIP_ERROR_INVALID_ARGUMENT);`
`786`		`- VerifyOrReturnError(csr_length > 0, CHIP_ERROR_INVALID_ARGUMENT);`
	`785`	`+ VerifyOrReturnError(isBufferNonEmpty(out_csr, csr_length), CHIP_ERROR_INVALID_ARGUMENT);`
`787`	`786`	`VerifyOrReturnError(mInitialized, CHIP_ERROR_WELL_UNINITIALIZED);`
`788`	`787`
`789`	`788`	`MutableByteSpan csr(out_csr, csr_length);`