Skip to content

Commit 7539363

Browse files
kghostpull[bot]
authored andcommitted
Fix minimal mDNS ResolvedNodeData::mAddress overflow (#12672)
1 parent a31a4ea commit 7539363

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/lib/dnssd/Resolver_ImplMinimalMdns.cpp

+4
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,10 @@ void PacketDataReporter::OnOperationalIPAddress(const chip::Inet::IPAddress & ad
178178
// This code assumes that all entries in the mDNS packet relate to the
179179
// same entity. This may not be correct if multiple servers are reported
180180
// (if multi-admin decides to use unique ports for every ecosystem).
181+
if (mNodeData.mNumIPs >= ResolvedNodeData::kMaxIPAddresses)
182+
{
183+
return;
184+
}
181185
mNodeData.mAddress[mNodeData.mNumIPs++] = addr;
182186
mNodeData.mInterfaceId = mInterfaceId;
183187
mHasIP = true;

0 commit comments

Comments
 (0)