Skip to content

Commit 884d9fa

Browse files
authoredSep 19, 2024··
Cleanup extra namespace prefix (#35664)
1 parent 3663d42 commit 884d9fa

10 files changed

+46
-50
lines changed
 

‎examples/fabric-admin/commands/fabric-sync/FabricSyncCommand.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ CHIP_ERROR FabricSyncRemoveLocalBridgeCommand::RunCommand()
274274
return CHIP_NO_ERROR;
275275
}
276276

277-
void FabricSyncDeviceCommand::OnCommissioningWindowOpened(NodeId deviceId, CHIP_ERROR err, chip::SetupPayload payload)
277+
void FabricSyncDeviceCommand::OnCommissioningWindowOpened(NodeId deviceId, CHIP_ERROR err, SetupPayload payload)
278278
{
279279
ChipLogProgress(NotSpecified, "FabricSyncDeviceCommand::OnCommissioningWindowOpened");
280280

‎examples/fabric-admin/commands/pairing/OpenCommissioningWindowCommand.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ CHIP_ERROR OpenCommissioningWindowCommand::RunCommand()
6868
}
6969

7070
void OpenCommissioningWindowCommand::OnOpenCommissioningWindowResponse(void * context, NodeId remoteId, CHIP_ERROR err,
71-
chip::SetupPayload payload)
71+
SetupPayload payload)
7272
{
7373
OnOpenBasicCommissioningWindowResponse(context, remoteId, err);
7474
}

‎examples/fabric-admin/commands/pairing/PairingCommand.cpp

+26-28
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ CommissioningParameters PairingCommand::GetCommissioningParameters()
169169

170170
if (!mICDSymmetricKey.HasValue())
171171
{
172-
chip::Crypto::DRBG_get_bytes(mRandomGeneratedICDSymmetricKey, sizeof(mRandomGeneratedICDSymmetricKey));
172+
Crypto::DRBG_get_bytes(mRandomGeneratedICDSymmetricKey, sizeof(mRandomGeneratedICDSymmetricKey));
173173
mICDSymmetricKey.SetValue(ByteSpan(mRandomGeneratedICDSymmetricKey));
174174
}
175175
if (!mICDCheckInNodeId.HasValue())
@@ -296,7 +296,7 @@ CHIP_ERROR PairingCommand::PairWithMdnsOrBleByIndexWithCode(NodeId remoteId, uin
296296
// There is no device with this index that has some resolution data. This could simply
297297
// be because the device is a ble device. In this case let's fall back to looking for
298298
// a device with this index and some RendezvousParameters.
299-
chip::SetupPayload payload;
299+
SetupPayload payload;
300300
bool isQRCode = strncmp(mOnboardingPayload, kQRCodePrefix, strlen(kQRCodePrefix)) == 0;
301301
if (isQRCode)
302302
{
@@ -336,21 +336,21 @@ CHIP_ERROR PairingCommand::PairWithMdns(NodeId remoteId)
336336
Dnssd::DiscoveryFilter filter(mFilterType);
337337
switch (mFilterType)
338338
{
339-
case chip::Dnssd::DiscoveryFilterType::kNone:
339+
case Dnssd::DiscoveryFilterType::kNone:
340340
break;
341-
case chip::Dnssd::DiscoveryFilterType::kShortDiscriminator:
342-
case chip::Dnssd::DiscoveryFilterType::kLongDiscriminator:
343-
case chip::Dnssd::DiscoveryFilterType::kCompressedFabricId:
344-
case chip::Dnssd::DiscoveryFilterType::kVendorId:
345-
case chip::Dnssd::DiscoveryFilterType::kDeviceType:
341+
case Dnssd::DiscoveryFilterType::kShortDiscriminator:
342+
case Dnssd::DiscoveryFilterType::kLongDiscriminator:
343+
case Dnssd::DiscoveryFilterType::kCompressedFabricId:
344+
case Dnssd::DiscoveryFilterType::kVendorId:
345+
case Dnssd::DiscoveryFilterType::kDeviceType:
346346
filter.code = mDiscoveryFilterCode;
347347
break;
348-
case chip::Dnssd::DiscoveryFilterType::kCommissioningMode:
348+
case Dnssd::DiscoveryFilterType::kCommissioningMode:
349349
break;
350-
case chip::Dnssd::DiscoveryFilterType::kCommissioner:
350+
case Dnssd::DiscoveryFilterType::kCommissioner:
351351
filter.code = 1;
352352
break;
353-
case chip::Dnssd::DiscoveryFilterType::kInstanceName:
353+
case Dnssd::DiscoveryFilterType::kInstanceName:
354354
filter.code = 0;
355355
filter.instanceName = mDiscoveryFilterInstanceName;
356356
break;
@@ -480,10 +480,10 @@ void PairingCommand::OnReadCommissioningInfo(const Controller::ReadCommissioning
480480

481481
void PairingCommand::OnICDRegistrationComplete(ScopedNodeId nodeId, uint32_t icdCounter)
482482
{
483-
char icdSymmetricKeyHex[chip::Crypto::kAES_CCM128_Key_Length * 2 + 1];
483+
char icdSymmetricKeyHex[Crypto::kAES_CCM128_Key_Length * 2 + 1];
484484

485-
chip::Encoding::BytesToHex(mICDSymmetricKey.Value().data(), mICDSymmetricKey.Value().size(), icdSymmetricKeyHex,
486-
sizeof(icdSymmetricKeyHex), chip::Encoding::HexFlags::kNullTerminate);
485+
Encoding::BytesToHex(mICDSymmetricKey.Value().data(), mICDSymmetricKey.Value().size(), icdSymmetricKeyHex,
486+
sizeof(icdSymmetricKeyHex), Encoding::HexFlags::kNullTerminate);
487487

488488
app::ICDClientInfo clientInfo;
489489
clientInfo.peer_node = nodeId;
@@ -521,15 +521,15 @@ void PairingCommand::OnICDStayActiveComplete(ScopedNodeId deviceId, uint32_t pro
521521
ChipLogValueX64(deviceId.GetNodeId()), promisedActiveDuration);
522522
}
523523

524-
void PairingCommand::OnDiscoveredDevice(const chip::Dnssd::CommissionNodeData & nodeData)
524+
void PairingCommand::OnDiscoveredDevice(const Dnssd::CommissionNodeData & nodeData)
525525
{
526526
// Ignore nodes with closed commissioning window
527527
VerifyOrReturn(nodeData.commissioningMode != 0);
528528

529529
auto & resolutionData = nodeData;
530530

531531
const uint16_t port = resolutionData.port;
532-
char buf[chip::Inet::IPAddress::kMaxStringLength];
532+
char buf[Inet::IPAddress::kMaxStringLength];
533533
resolutionData.ipAddress[0].ToString(buf);
534534
ChipLogProgress(NotSpecified, "Discovered Device: %s:%u", buf, port);
535535

@@ -566,8 +566,7 @@ void PairingCommand::OnCurrentFabricRemove(void * context, NodeId nodeId, CHIP_E
566566
fprintf(stderr, "Device with Node ID: 0x%lx has been successfully removed.\n", nodeId);
567567

568568
#if defined(PW_RPC_ENABLED)
569-
chip::app::InteractionModelEngine::GetInstance()->ShutdownSubscriptions(command->CurrentCommissioner().GetFabricIndex(),
570-
nodeId);
569+
app::InteractionModelEngine::GetInstance()->ShutdownSubscriptions(command->CurrentCommissioner().GetFabricIndex(), nodeId);
571570
RemoveSynchronizedDevice(nodeId);
572571
#endif
573572
}
@@ -586,10 +585,10 @@ void PairingCommand::OnCurrentFabricRemove(void * context, NodeId nodeId, CHIP_E
586585
command->SetCommandExitStatus(err);
587586
}
588587

589-
chip::Optional<uint16_t> PairingCommand::FailSafeExpiryTimeoutSecs() const
588+
Optional<uint16_t> PairingCommand::FailSafeExpiryTimeoutSecs() const
590589
{
591590
// No manual input, so do not need to extend.
592-
return chip::Optional<uint16_t>();
591+
return Optional<uint16_t>();
593592
}
594593

595594
bool PairingCommand::ShouldWaitAfterDeviceAttestation()
@@ -603,10 +602,9 @@ bool PairingCommand::ShouldWaitAfterDeviceAttestation()
603602
return err == CHIP_NO_ERROR && (payload.vendorID != 0 || payload.productID != 0);
604603
}
605604

606-
void PairingCommand::OnDeviceAttestationCompleted(chip::Controller::DeviceCommissioner * deviceCommissioner,
607-
chip::DeviceProxy * device,
608-
const chip::Credentials::DeviceAttestationVerifier::AttestationDeviceInfo & info,
609-
chip::Credentials::AttestationVerificationResult attestationResult)
605+
void PairingCommand::OnDeviceAttestationCompleted(Controller::DeviceCommissioner * deviceCommissioner, DeviceProxy * device,
606+
const Credentials::DeviceAttestationVerifier::AttestationDeviceInfo & info,
607+
Credentials::AttestationVerificationResult attestationResult)
610608
{
611609
SetupPayload payload;
612610
CHIP_ERROR parse_error = GetPayload(mOnboardingPayload, payload);
@@ -619,7 +617,7 @@ void PairingCommand::OnDeviceAttestationCompleted(chip::Controller::DeviceCommis
619617
"Requested VID: %u, Requested PID: %u.",
620618
payload.vendorID, payload.productID);
621619
deviceCommissioner->ContinueCommissioningAfterDeviceAttestation(
622-
device, chip::Credentials::AttestationVerificationResult::kInvalidArgument);
620+
device, Credentials::AttestationVerificationResult::kInvalidArgument);
623621
return;
624622
}
625623

@@ -633,8 +631,8 @@ void PairingCommand::OnDeviceAttestationCompleted(chip::Controller::DeviceCommis
633631
deviceCommissioner->ContinueCommissioningAfterDeviceAttestation(
634632
device,
635633
payload.vendorID == info.BasicInformationVendorId()
636-
? chip::Credentials::AttestationVerificationResult::kDacProductIdMismatch
637-
: chip::Credentials::AttestationVerificationResult::kDacVendorIdMismatch);
634+
? Credentials::AttestationVerificationResult::kDacProductIdMismatch
635+
: Credentials::AttestationVerificationResult::kDacVendorIdMismatch);
638636
return;
639637
}
640638

@@ -654,7 +652,7 @@ void PairingCommand::OnDeviceAttestationCompleted(chip::Controller::DeviceCommis
654652
{
655653
// Bypass attestation verification, continue with success
656654
auto err = deviceCommissioner->ContinueCommissioningAfterDeviceAttestation(
657-
device, chip::Credentials::AttestationVerificationResult::kSuccess);
655+
device, Credentials::AttestationVerificationResult::kSuccess);
658656
if (CHIP_NO_ERROR != err)
659657
{
660658
SetCommandExitStatus(err);

‎examples/fabric-admin/device_manager/DeviceManager.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ void DeviceManager::OpenRemoteDeviceCommissioningWindow(EndpointId remoteEndpoin
150150
}
151151
}
152152

153-
void DeviceManager::PairRemoteFabricBridge(chip::NodeId nodeId, uint32_t setupPINCode, const char * deviceRemoteIp,
153+
void DeviceManager::PairRemoteFabricBridge(NodeId nodeId, uint32_t setupPINCode, const char * deviceRemoteIp,
154154
uint16_t deviceRemotePort)
155155
{
156156
StringBuilder<kMaxCommandSize> commandBuilder;
@@ -240,7 +240,7 @@ void DeviceManager::ReadSupportedDeviceCategories()
240240
PushCommand(commandBuilder.c_str());
241241
}
242242

243-
void DeviceManager::HandleReadSupportedDeviceCategories(chip::TLV::TLVReader & data)
243+
void DeviceManager::HandleReadSupportedDeviceCategories(TLV::TLVReader & data)
244244
{
245245
ChipLogProgress(NotSpecified, "Attribute SupportedDeviceCategories detected.");
246246

@@ -305,7 +305,7 @@ void DeviceManager::HandleCommissioningRequestResult(TLV::TLVReader & data)
305305
SendCommissionNodeRequest(value.requestID, kResponseTimeoutSeconds);
306306
}
307307

308-
void DeviceManager::HandleAttributePartsListUpdate(chip::TLV::TLVReader & data)
308+
void DeviceManager::HandleAttributePartsListUpdate(TLV::TLVReader & data)
309309
{
310310
ChipLogProgress(NotSpecified, "Attribute PartsList change detected:");
311311

‎examples/fabric-admin/device_manager/DeviceSubscription.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ void DeviceSubscription::OnAttributeData(const ConcreteDataAttributePath & path,
8585
}
8686
case Clusters::AdministratorCommissioning::Attributes::AdminVendorId::Id: {
8787
#if defined(PW_RPC_ENABLED)
88-
chip::VendorId vendorId;
88+
VendorId vendorId;
8989
CHIP_ERROR err = data->Get(vendorId);
9090
mCurrentAdministratorCommissioningAttributes.has_opener_vendor_id = err == CHIP_NO_ERROR;
9191
if (mCurrentAdministratorCommissioningAttributes.has_opener_vendor_id)

‎examples/fabric-admin/device_manager/DeviceSubscriptionManager.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ CHIP_ERROR DeviceSubscriptionManager::StartSubscription(Controller::DeviceContro
5353
return CHIP_NO_ERROR;
5454
}
5555

56-
CHIP_ERROR DeviceSubscriptionManager::RemoveSubscription(chip::NodeId nodeId)
56+
CHIP_ERROR DeviceSubscriptionManager::RemoveSubscription(NodeId nodeId)
5757
{
5858
assertChipStackLockedByCurrentThread();
5959
auto it = mDeviceSubscriptionMap.find(nodeId);

‎examples/fabric-admin/device_manager/DeviceSynchronization.cpp

+4-6
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ void DeviceSynchronizer::OnReportEnd()
138138
MoveToState(State::ReceivedResponse);
139139
}
140140

141-
void DeviceSynchronizer::OnDone(chip::app::ReadClient * apReadClient)
141+
void DeviceSynchronizer::OnDone(app::ReadClient * apReadClient)
142142
{
143143
#if defined(PW_RPC_ENABLED)
144144
if (mState == State::ReceivedResponse && !DeviceMgr().IsCurrentBridgeDevice(mNodeId))
@@ -163,8 +163,7 @@ void DeviceSynchronizer::OnError(CHIP_ERROR error)
163163
ChipLogProgress(NotSpecified, "Error fetching device data: %" CHIP_ERROR_FORMAT, error.Format());
164164
}
165165

166-
void DeviceSynchronizer::OnDeviceConnected(chip::Messaging::ExchangeManager & exchangeMgr,
167-
const chip::SessionHandle & sessionHandle)
166+
void DeviceSynchronizer::OnDeviceConnected(Messaging::ExchangeManager & exchangeMgr, const SessionHandle & sessionHandle)
168167
{
169168
mClient = std::make_unique<ReadClient>(app::InteractionModelEngine::GetInstance(), &exchangeMgr /* echangeMgr */,
170169
*this /* callback */, ReadClient::InteractionType::Read);
@@ -188,14 +187,13 @@ void DeviceSynchronizer::OnDeviceConnected(chip::Messaging::ExchangeManager & ex
188187
MoveToState(State::AwaitingResponse);
189188
}
190189

191-
void DeviceSynchronizer::OnDeviceConnectionFailure(const chip::ScopedNodeId & peerId, CHIP_ERROR error)
190+
void DeviceSynchronizer::OnDeviceConnectionFailure(const ScopedNodeId & peerId, CHIP_ERROR error)
192191
{
193192
ChipLogError(NotSpecified, "Device Sync failed to connect to " ChipLogFormatX64, ChipLogValueX64(peerId.GetNodeId()));
194193
MoveToState(State::Idle);
195194
}
196195

197-
void DeviceSynchronizer::StartDeviceSynchronization(chip::Controller::DeviceController * controller, chip::NodeId nodeId,
198-
bool deviceIsIcd)
196+
void DeviceSynchronizer::StartDeviceSynchronization(Controller::DeviceController * controller, NodeId nodeId, bool deviceIsIcd)
199197
{
200198
VerifyOrDie(controller);
201199
if (mState != State::Idle)

‎examples/fabric-admin/device_manager/UniqueIdGetter.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ UniqueIdGetter::UniqueIdGetter() :
5353
mOnDeviceConnectionFailureCallback(OnDeviceConnectionFailureWrapper, this)
5454
{}
5555

56-
CHIP_ERROR UniqueIdGetter::GetUniqueId(OnDoneCallback onDoneCallback, chip::Controller::DeviceController & controller,
57-
chip::NodeId nodeId, chip::EndpointId endpointId)
56+
CHIP_ERROR UniqueIdGetter::GetUniqueId(OnDoneCallback onDoneCallback, Controller::DeviceController & controller, NodeId nodeId,
57+
EndpointId endpointId)
5858
{
5959
assertChipStackLockedByCurrentThread();
6060
VerifyOrDie(!mCurrentlyGettingUid);

‎examples/fabric-admin/rpc/RpcClient.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ CHIP_ERROR AddSynchronizedDevice(const chip_rpc_SynchronizedDevice & data)
144144
return WaitForResponse(call);
145145
}
146146

147-
CHIP_ERROR RemoveSynchronizedDevice(chip::NodeId nodeId)
147+
CHIP_ERROR RemoveSynchronizedDevice(NodeId nodeId)
148148
{
149149
ChipLogProgress(NotSpecified, "RemoveSynchronizedDevice");
150150

@@ -164,7 +164,7 @@ CHIP_ERROR RemoveSynchronizedDevice(chip::NodeId nodeId)
164164
return WaitForResponse(call);
165165
}
166166

167-
CHIP_ERROR ActiveChanged(chip::NodeId nodeId, uint32_t promisedActiveDurationMs)
167+
CHIP_ERROR ActiveChanged(NodeId nodeId, uint32_t promisedActiveDurationMs)
168168
{
169169
ChipLogProgress(NotSpecified, "ActiveChanged");
170170

‎examples/fabric-admin/rpc/RpcServer.cpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ namespace {
4545
class FabricAdmin final : public rpc::FabricAdmin, public IcdManager::Delegate
4646
{
4747
public:
48-
void OnCheckInCompleted(const chip::app::ICDClientInfo & clientInfo) override
48+
void OnCheckInCompleted(const app::ICDClientInfo & clientInfo) override
4949
{
5050
// Accessing mPendingCheckIn should only be done while holding ChipStackLock
5151
assertChipStackLockedByCurrentThread();
@@ -76,7 +76,7 @@ class FabricAdmin final : public rpc::FabricAdmin, public IcdManager::Delegate
7676
// addressed, we can implement what spec defines here.
7777
auto onDone = [=](uint32_t promisedActiveDuration) { ActiveChanged(nodeId, promisedActiveDuration); };
7878
CHIP_ERROR err = StayActiveSender::SendStayActiveCommand(checkInData.mStayActiveDurationMs, clientInfo.peer_node,
79-
chip::app::InteractionModelEngine::GetInstance(), onDone);
79+
app::InteractionModelEngine::GetInstance(), onDone);
8080
if (err != CHIP_NO_ERROR)
8181
{
8282
ChipLogError(NotSpecified, "Failed to send StayActive command %s", err.AsString());
@@ -156,7 +156,7 @@ class FabricAdmin final : public rpc::FabricAdmin, public IcdManager::Delegate
156156
KeepActiveWorkData * data =
157157
Platform::New<KeepActiveWorkData>(this, request.node_id, request.stay_active_duration_ms, request.timeout_ms);
158158
VerifyOrReturnValue(data, pw::Status::Internal());
159-
chip::DeviceLayer::PlatformMgr().ScheduleWork(KeepActiveWork, reinterpret_cast<intptr_t>(data));
159+
DeviceLayer::PlatformMgr().ScheduleWork(KeepActiveWork, reinterpret_cast<intptr_t>(data));
160160
return pw::OkStatus();
161161
}
162162

@@ -194,7 +194,7 @@ class FabricAdmin final : public rpc::FabricAdmin, public IcdManager::Delegate
194194
{}
195195

196196
FabricAdmin * mFabricAdmin;
197-
chip::NodeId mNodeId;
197+
NodeId mNodeId;
198198
uint32_t mStayActiveDurationMs;
199199
uint32_t mTimeoutMs;
200200
};
@@ -203,7 +203,7 @@ class FabricAdmin final : public rpc::FabricAdmin, public IcdManager::Delegate
203203
{
204204
KeepActiveWorkData * data = reinterpret_cast<KeepActiveWorkData *>(arg);
205205
data->mFabricAdmin->ScheduleSendingKeepActiveOnCheckIn(data->mNodeId, data->mStayActiveDurationMs, data->mTimeoutMs);
206-
chip::Platform::Delete(data);
206+
Platform::Delete(data);
207207
}
208208

209209
// Modifications to mPendingCheckIn should be done on the MatterEventLoop thread

0 commit comments

Comments
 (0)
Please sign in to comment.