Skip to content

Commit 90245cb

Browse files
address comments
1 parent f913ada commit 90245cb

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/controller/CHIPDeviceController.cpp

+5-2
Original file line numberDiff line numberDiff line change
@@ -2376,6 +2376,9 @@ CHIP_ERROR DeviceCommissioner::ParseICDInfo(ReadCommissioningInfo & info)
23762376

23772377
if (!isICD)
23782378
{
2379+
info.icd.idleModeDuration = 0;
2380+
info.icd.activeModeDuration = 0;
2381+
info.icd.activeModeThreshold = 0;
23792382
return CHIP_NO_ERROR;
23802383
}
23812384

@@ -2389,15 +2392,15 @@ CHIP_ERROR DeviceCommissioner::ParseICDInfo(ReadCommissioningInfo & info)
23892392
mAttributeCache->Get<IcdManagement::Attributes::ActiveModeDuration::TypeInfo>(kRootEndpointId, info.icd.activeModeDuration);
23902393
if (err != CHIP_NO_ERROR)
23912394
{
2392-
ChipLogError(Controller, "IcdManagement.ActiveModeDuration expected, but failed to read.");
2395+
ChipLogError(Controller, "IcdManagement.ActiveModeDuration expected, but failed to read: %" CHIP_ERROR_FORMAT, err.Format());
23932396
return err;
23942397
}
23952398

23962399
err = mAttributeCache->Get<IcdManagement::Attributes::ActiveModeThreshold::TypeInfo>(kRootEndpointId,
23972400
info.icd.activeModeThreshold);
23982401
if (err != CHIP_NO_ERROR)
23992402
{
2400-
ChipLogError(Controller, "IcdManagement.ActiveModeThreshold expected, but failed to read.");
2403+
ChipLogError(Controller, "IcdManagement.ActiveModeThreshold expected, but failed to read: %" CHIP_ERROR_FORMAT, err.Format());
24012404
}
24022405

24032406
return err;

0 commit comments

Comments
 (0)