Remove unnecessary error log from CurrentFabricRemover

agners · agners · commit 9244a248fb15 · 2024-06-13T11:06:54.000+02:00
Currently, when the CurrentFabricRemover is successful it logs the
following error with err log level:

Remove Current Fabric Result : src/controller/CurrentFabricRemover.cpp:133: Success

Get rid of the message if successful, it is confusing.
diff --git a/src/controller/CurrentFabricRemover.cpp b/src/controller/CurrentFabricRemover.cpp
@@ -145,7 +145,8 @@ void CurrentFabricRemover::OnCommandFailure(void * context, CHIP_ERROR err)
 
 void CurrentFabricRemover::FinishRemoveCurrentFabric(void * context, CHIP_ERROR err)
 {
-    ChipLogError(Controller, "Remove Current Fabric Result : %" CHIP_ERROR_FORMAT, err.Format());
+    if (err != CHIP_NO_ERROR)
+        ChipLogError(Controller, "Remove Current Fabric Failed : %" CHIP_ERROR_FORMAT, err.Format());
     auto * self     = static_cast<CurrentFabricRemover *>(context);
     self->mNextStep = Step::kAcceptRemoveFabricStart;
     if (self->mCurrentFabricRemoveCallback != nullptr)

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,8 @@ void CurrentFabricRemover::OnCommandFailure(void * context, CHIP_ERROR err)`
`145`	`145`
`146`	`146`	`void CurrentFabricRemover::FinishRemoveCurrentFabric(void * context, CHIP_ERROR err)`
`147`	`147`	`{`
`148`		`- ChipLogError(Controller, "Remove Current Fabric Result : %" CHIP_ERROR_FORMAT, err.Format());`
	`148`	`+ if (err != CHIP_NO_ERROR)`
	`149`	`+ ChipLogError(Controller, "Remove Current Fabric Failed : %" CHIP_ERROR_FORMAT, err.Format());`
`149`	`150`	`auto * self = static_cast<CurrentFabricRemover *>(context);`
`150`	`151`	`self->mNextStep = Step::kAcceptRemoveFabricStart;`
`151`	`152`	`if (self->mCurrentFabricRemoveCallback != nullptr)`